Date: Sat, 13 Jan 2018 14:58:06 -0500 From: Allan Jude <allanjude@freebsd.org> To: "Pedro F. Giffuni" <pfg@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r327934 - head/sys/contrib/zstd/lib/freebsd Message-ID: <63f8d491-edef-5b92-8b4c-04f64c15c847@freebsd.org> In-Reply-To: <CAG6CVpXZzj82TWTvju0CyaJamVZX%2BM3AT7WwFeAy%2B7N%2Bbo9jtQ@mail.gmail.com> References: <201801131809.w0DI9AZw072646@repo.freebsd.org> <CAG6CVpXZzj82TWTvju0CyaJamVZX%2BM3AT7WwFeAy%2B7N%2Bbo9jtQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2018-01-13 14:23, Conrad Meyer wrote: > On Sat, Jan 13, 2018 at 10:09 AM, Pedro F. Giffuni <pfg@freebsd.org> wrote: >> Author: pfg >> Date: Sat Jan 13 18:09:09 2018 >> New Revision: 327934 >> URL: https://svnweb.freebsd.org/changeset/base/327934 >> >> Log: >> zstd: Use memalloc(9) for calloc macro. >> >> This is in contrib code but since we only have memalloc(9) in current we >> will not upstream this. > > Fortunately, zstd_kfreebsd.h is not contrib code but local code. We > don't have to worry about upstreaming this change. Please consider > including review from Allan Jude, Warner, or myself on future zstd > changes. We've tried to be very careful not to modify contrib code. > > For the record, though, I approve this change. > > Best, > Conrad > >> Modified: >> head/sys/contrib/zstd/lib/freebsd/zstd_kfreebsd.h > Looks good to me too -- Allan Jude
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?63f8d491-edef-5b92-8b4c-04f64c15c847>