Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 24 Aug 2013 13:03:10 -0600
From:      "Kenneth D. Merry" <ken@FreeBSD.org>
To:        Glen Barber <gjb@FreeBSD.org>
Cc:        svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org
Subject:   Re: svn commit: r254760 - in head: share/man/man4 sys/cam/scsi sys/kern sys/sys
Message-ID:  <20130824190310.GA62787@nargothrond.kdm.org>
In-Reply-To: <20130824164446.GA41859@glenbarber.us>
References:  <201308240452.r7O4qMji033904@svn.freebsd.org> <20130824164446.GA41859@glenbarber.us>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Aug 24, 2013 at 12:44:46 -0400, Glen Barber wrote:
> On Sat, Aug 24, 2013 at 04:52:22AM +0000, Kenneth D. Merry wrote:
> > Author: ken
> > Date: Sat Aug 24 04:52:22 2013
> > New Revision: 254760
> > URL: http://svnweb.freebsd.org/changeset/base/254760
> > 
> 
> > [...]
> 
> > @@ -83,6 +113,17 @@ physio(struct cdev *dev, struct uio *uio
> >  			 */
> >  			iolen = ((vm_offset_t) bp->b_data) & PAGE_MASK;
> >  			if ((bp->b_bcount + iolen) > bp->b_kvasize) {
> > +				/*
> > +				 * This device does not want I/O to be split.
> > +				 */
> > +				if (dev->si_flags & SI_NOSPLIT) {
> > +					printf("%s: request ptr %#jx is not "
> > +					    "on a page boundary, cannot split "
> > +					    "request\n", devtoname(dev),
> > +					    (uintmax_t)bp->b_data);
> 
> This breaks LINT for at least powerpc.
> 
> cc1: warnings being treated as errors
> /src/sys/kern/kern_physio.c: In function 'physio':
> /src/sys/kern/kern_physio.c:123: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> *** Error code 1
> 
> 
> http://tinderbox.freebsd.org/tinderbox-head-build-HEAD-powerpc-powerpc.full

Oops, sorry about that!

Fixed.

Ken
-- 
Kenneth Merry
ken@FreeBSD.ORG



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130824190310.GA62787>