Date: Mon, 10 Aug 2020 22:37:50 -0700 From: Gleb Smirnoff <glebius@freebsd.org> To: Hans Petter Selasky <hselasky@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r364072 - in head/sys: netinet netinet6 Message-ID: <20200811053750.GB1307@FreeBSD.org> In-Reply-To: <202008101040.07AAeK4e096973@repo.freebsd.org> References: <202008101040.07AAeK4e096973@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hans, On Mon, Aug 10, 2020 at 10:40:20AM +0000, Hans Petter Selasky wrote: H> Author: hselasky H> Date: Mon Aug 10 10:40:19 2020 H> New Revision: 364072 H> URL: https://svnweb.freebsd.org/changeset/base/364072 H> H> Log: H> Use proper prototype for SYSINIT() functions. H> Mark the unused argument using the __unused macro. H> H> Discussed with: kib@ H> MFC after: 1 week H> Sponsored by: Mellanox Technologies Why just do not use the SYSINIT at all? Index: in_mcast.c =================================================================== --- in_mcast.c (revision 364098) +++ in_mcast.c (working copy) @@ -229,17 +229,10 @@ inm_is_ifp_detached(const struct in_multi *inm) * dedicated thread to avoid deadlocks when draining inm_release tasks. */ TASKQUEUE_DEFINE_THREAD(inm_free); -static struct task inm_free_task; static struct in_multi_head inm_free_list = SLIST_HEAD_INITIALIZER(); static void inm_release_task(void *arg __unused, int pending __unused); +static struct task inm_free_task = TASK_INITIALIZER(0, inm_release_task, NULL); -static void -inm_init(void *arg __unused) -{ - TASK_INIT(&inm_free_task, 0, inm_release_task, NULL); -} -SYSINIT(inm_init, SI_SUB_TASKQ, SI_ORDER_ANY, inm_init, NULL); - void inm_release_wait(void *arg __unused) { Same for inm6. -- Gleb Smirnoff
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200811053750.GB1307>