Date: Mon, 29 Nov 1999 18:35:40 -0500 (EST) From: "Viren R.Shah" <viren@rstcorp.com> To: Matthew Dillon <dillon@apollo.backplane.com> Cc: freebsd-current@FreeBSD.org Subject: Re: repeatable crash in -current (softupdates, NFS) Message-ID: <14403.3532.973553.40985@jabberwock.rstcorp.com> In-Reply-To: <199911292325.PAA12356@apollo.backplane.com> References: <14399.63511.296802.242618@jabberwock.rstcorp.com> <19991127191729.A53832@bitbox.follo.net> <14402.62122.461010.454021@jabberwock.rstcorp.com> <199911292152.NAA09656@apollo.backplane.com> <19991129235631.P60031@bitbox.follo.net> <199911292308.PAA12218@apollo.backplane.com> <19991130001724.S60031@bitbox.follo.net> <199911292325.PAA12356@apollo.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
>>>>> "Matt" == Matthew Dillon <dillon@apollo.backplane.com> writes:
Matt> I've added a little cleanup to this patch. Viren, please try this
Matt> patch.
Matt> -Matt
Matt> Matthew Dillon
Matt> <dillon@backplane.com>
Matt> Index: nfs_vnops.c
Matt> ===================================================================
Matt> RCS file: /FreeBSD/FreeBSD-CVS/src/sys/nfs/nfs_vnops.c,v
Matt> retrieving revision 1.146
Matt> diff -u -r1.146 nfs_vnops.c
Matt> --- nfs_vnops.c 1999/11/27 18:14:41 1.146
Matt> +++ nfs_vnops.c 1999/11/29 23:23:05
Matt> @@ -1806,11 +1806,10 @@
Matt> txdr_nfsv2time(&vap->va_mtime, &sp->sa_mtime);
Matt> }
Matt> nfsm_request(dvp, NFSPROC_SYMLINK, cnp->cn_proc, cnp->cn_cred);
Matt> - if (v3) {
Matt> - if (!error)
Matt> - nfsm_mtofh(dvp, newvp, v3, gotvp);
Matt> + if (!error)
Matt> + nfsm_mtofh(dvp, newvp, v3, gotvp);
^^^^^^^^^^
Should that still be "v3"? Since you moved it out of the "if (v3)"
block, sholudn't it say something else?
Viren
--
Viren Shah | "You can't trust code that you did not totally
Research Associate, RST Inc. | create yourself. (Especially code from
viren@rstcorp.com | companies that employ people like me.)"
http://www.rstcorp.com/~vshah | - Ken Thompson "Reflections on Trusting Trust"
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?14403.3532.973553.40985>