Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 22 Jun 1996 16:29:17 +1000
From:      Bruce Evans <bde@zeta.org.au>
To:        CVS-committers@freefall.freebsd.org, ache@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-gnu@freefall.freebsd.org
Subject:   Re: cvs commit:  src/gnu/usr.bin/man/man Makefile man.c
Message-ID:  <199606220629.QAA21238@godzilla.zeta.org.au>

next in thread | raw e-mail | index | archive | help
>  Modified:    gnu/usr.bin/man/man  Makefile man.c
>  Log:
>  Close security holes and restore suid bit
>  Restore writting cat's functionality

>  Revision  Changes    Path
>  1.16      +2 -0      src/gnu/usr.bin/man/man/Makefile
>  1.15      +123 -46   src/gnu/usr.bin/man/man/man.c

This should have been reviewed.  I found a bug easily:

$ man -d ls
[Nothing interestting]
$ su
# mkdir /usr/share/man/cat1	# I don't have cat directories
# chown man /usr/share/man/cat1
# exit
$ man -d ls
[Nothing interesting]
$ man ls
zcat: /usr/share/man/cat1/ls.1.gz: unexpected end of file
[file is 0 bytes long]

The old version built the cat file normally even in the debugging case.

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199606220629.QAA21238>