Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 23 Feb 2021 00:33:24 GMT
From:      Alexander Motin <mav@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 7cc6daf122e5 - stable/12 - Exclude reserved iSCSI Target Transfer Tag.
Message-ID:  <202102230033.11N0XO9x062852@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/12 has been updated by mav:

URL: https://cgit.FreeBSD.org/src/commit/?id=7cc6daf122e53859ba786716090d1d536249a793

commit 7cc6daf122e53859ba786716090d1d536249a793
Author:     Alexander Motin <mav@FreeBSD.org>
AuthorDate: 2021-01-24 18:58:29 +0000
Commit:     Alexander Motin <mav@FreeBSD.org>
CommitDate: 2021-02-23 00:33:19 +0000

    Exclude reserved iSCSI Target Transfer Tag.
    
    RFC 7143 (11.7.4):
       The Target Transfer Tag values are not specified by this protocol,
       except that the value 0xffffffff is reserved and means that the
       Target Transfer Tag is not supplied.
    
    MFC after:      1 month
---
 sys/cam/ctl/ctl_frontend_iscsi.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/sys/cam/ctl/ctl_frontend_iscsi.c b/sys/cam/ctl/ctl_frontend_iscsi.c
index dfe1a347844b..9b55574590ff 100644
--- a/sys/cam/ctl/ctl_frontend_iscsi.c
+++ b/sys/cam/ctl/ctl_frontend_iscsi.c
@@ -2659,6 +2659,10 @@ cfiscsi_datamove_out(union ctl_io *io)
 
 	target_transfer_tag =
 	    atomic_fetchadd_32(&cs->cs_target_transfer_tag, 1);
+	if (target_transfer_tag == 0xffffffff) {
+		target_transfer_tag =
+		    atomic_fetchadd_32(&cs->cs_target_transfer_tag, 1);
+	}
 	cdw = cfiscsi_data_wait_new(cs, io, bhssc->bhssc_initiator_task_tag,
 	    &target_transfer_tag);
 	if (cdw == NULL) {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202102230033.11N0XO9x062852>