Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 24 Jul 2026 22:45:40 +0000
From:      Enji Cooper <ngie@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: a594783bac90 - main - linux_firmware: reformat error print-out
Message-ID:  <6a63eb14.19efc.36f751fb@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch main has been updated by ngie:

URL: https://cgit.FreeBSD.org/src/commit/?id=a594783bac906ecc4f6528d7d576215f85a21bda

commit a594783bac906ecc4f6528d7d576215f85a21bda
Author:     Enji Cooper <ngie@FreeBSD.org>
AuthorDate: 2026-07-21 16:08:44 +0000
Commit:     Enji Cooper <ngie@FreeBSD.org>
CommitDate: 2026-07-24 22:45:34 +0000

    linux_firmware: reformat error print-out
    
    This makes it easier to grep for the error message to better understand
    the call stack when loading firmware modules fails.
    
    Fix a cosmetic-only style(9) bug while here in the same function related
    to another logging message.
    
    MFC after:      1 week
    Differential Revision:  https://reviews.freebsd.org/D58380
---
 sys/compat/linuxkpi/common/src/linux_firmware.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/sys/compat/linuxkpi/common/src/linux_firmware.c b/sys/compat/linuxkpi/common/src/linux_firmware.c
index 0c6d855501ef..0915b317c01e 100644
--- a/sys/compat/linuxkpi/common/src/linux_firmware.c
+++ b/sys/compat/linuxkpi/common/src/linux_firmware.c
@@ -131,12 +131,13 @@ _linuxkpi_request_firmware(const char *fw_name, const struct linuxkpi_firmware *
 			*fw = NULL;
 		}
 		if (warn)
-			device_printf(dev->bsddev, "could not load firmware "
-			    "image '%s'\n", fw_name);
+			device_printf(dev->bsddev,
+			    "could not load firmware image '%s'\n",
+			    fw_name);
 		return (-ENOENT);
 	}
 
-	device_printf(dev->bsddev,"successfully loaded firmware image '%s'\n",
+	device_printf(dev->bsddev, "successfully loaded firmware image '%s'\n",
 	    fw_name);
 	lfw->fbdfw = fbdfw;
 	lfw->data = (const uint8_t *)fbdfw->data;


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6a63eb14.19efc.36f751fb>