Date: Sat, 14 Apr 2007 22:13:22 -0400 From: Kris Kennaway <kris@obsecurity.org> To: Dejan Lesjak <dejan.lesjak@ijs.si> Cc: x11@freebsd.org, Kris Kennaway <kris@obsecurity.org> Subject: Re: Upgrade script Message-ID: <20070415021322.GB77534@xor.obsecurity.org> In-Reply-To: <200704150410.46839.dejan.lesjak@ijs.si> References: <20070414194028.GB2313@xor.obsecurity.org> <200704142311.47387.dejan.lesjak@ijs.si> <20070415013921.GA68262@xor.obsecurity.org> <200704150410.46839.dejan.lesjak@ijs.si>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Sun, Apr 15, 2007 at 04:10:46AM +0200, Dejan Lesjak wrote:
> On Sunday 15 April 2007 03:39:22 Kris Kennaway wrote:
> > One more thing I spotted is that it doesn't handle
> > non-default X11BASE or LOCALBASE. Probably the way to do this is to
> > use
> >
> > PORTSDIR?=/usr/ports
> > X11BASE=`make -f ${PORTSDIR}/Mk/bsd.port.mk -V X11BASE`
> >
> > or similar. Using bsd.port.mk is so it picks up the default value,
> > and includes /etc/make.conf to check for override. It also DTRT if
> > X11BASE is set in the environment.
>
> Hmm. I wouldn't use too much automagic in that case. I'm not sure it's good to
> assume that if someone has changed the defaults that this script will do the
> right thing for them regardless if it properly detects changed
> X11BASE/LOCALBASE. I'd rather say they can change variables at beginning of
> the script. Perhaps printing the message saying that this should be changed
> if using non-default (and also to change BACKUPDIR) and then ask for
> confirmation to continue?
Yes, that is probably best.
Kris
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (FreeBSD)
iD8DBQFGIYpCWry0BWjoQKURAlTBAJ0YcyLj2jKfDPNEaKDVDedj90QWKwCcCU+V
UjSTRitK3JrTetgFlGlJyx8=
=1kw+
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070415021322.GB77534>