Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 1 Nov 2018 07:07:03 +0000
From:      Alexey Dokuchaev <danfe@freebsd.org>
To:        "Jason E. Hale" <jhale@freebsd.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r483626 - head/audio/taglib
Message-ID:  <20181101070703.GA45853@FreeBSD.org>
In-Reply-To: <201810312326.w9VNQdgV020234@repo.freebsd.org>
References:  <201810312326.w9VNQdgV020234@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Oct 31, 2018 at 11:26:39PM +0000, Jason E. Hale wrote:
> New Revision: 483626
> URL: https://svnweb.freebsd.org/changeset/ports/483626
> 
> Log:
>   audio/taglib: Fix build on powerpc64
>   
>   PR:		232812

Looks like commit message is not accurate.  From the PR, he says that
c++11-lang is needed to fix "linking of devel/kf5-kfilemetadata on GCC
architectures", not the build of the port itself.

Given the lack of context in those PRs by Piotr Kubaj I'd suggest we
give a closer look when dealing with them; at the very least, commit
logs should adequately describe the problem being fixed.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20181101070703.GA45853>