Skip site navigation (1)Skip section navigation (2) 
Date:      Mon, 15 Mar 2021 03:01:28 GMT
From:      Alexander Motin <mav@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 748feb192e2a - stable/12 - Optimize out few extra memory accesses.
Message-ID:  <202103150301.12F31Sr8097988@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
The branch stable/12 has been updated by mav:

URL: https://cgit.FreeBSD.org/src/commit/?id=748feb192e2a36a9479a9f363d0b621bae614597

commit 748feb192e2a36a9479a9f363d0b621bae614597
Author:     Alexander Motin <mav@FreeBSD.org>
AuthorDate: 2021-03-01 23:35:45 +0000
Commit:     Alexander Motin <mav@FreeBSD.org>
CommitDate: 2021-03-15 02:46:11 +0000

    Optimize out few extra memory accesses.
    
    MFC after:      1 week
    
    (cherry picked from commit a59e2982fe3e6339629cc77fe9d349d60e03a05e)
---
 sys/cam/ctl/ctl_backend_block.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sys/cam/ctl/ctl_backend_block.c b/sys/cam/ctl/ctl_backend_block.c
index abcd8d6e6fae..54026844f695 100644
--- a/sys/cam/ctl/ctl_backend_block.c
+++ b/sys/cam/ctl/ctl_backend_block.c
@@ -418,7 +418,6 @@ ctl_be_block_move_done(union ctl_io *io, bool samethr)
 	struct ctl_lba_len_flags *lbalen;
 
 	beio = (struct ctl_be_block_io *)PRIV(io)->ptr;
-	be_lun = beio->lun;
 
 	DPRINTF("entered\n");
 	io->scsiio.kern_rel_offset += io->scsiio.kern_data_len;
@@ -428,7 +427,7 @@ ctl_be_block_move_done(union ctl_io *io, bool samethr)
 	 */
 	if ((io->io_hdr.flags & CTL_FLAG_ABORT) == 0 &&
 	    (io->io_hdr.status & CTL_STATUS_MASK) == CTL_STATUS_NONE) {
-		lbalen = ARGS(beio->io);
+		lbalen = ARGS(io);
 		if (lbalen->flags & CTL_LLF_READ) {
 			ctl_set_success(&io->scsiio);
 		} else if (lbalen->flags & CTL_LLF_COMPARE) {
@@ -456,6 +455,7 @@ ctl_be_block_move_done(union ctl_io *io, bool samethr)
 	 * This move done routine is generally called in the SIM's
 	 * interrupt context, and therefore we cannot block.
 	 */
+	be_lun = (struct ctl_be_block_lun *)CTL_BACKEND_LUN(io);
 	if (samethr) {
 		be_lun->dispatch(be_lun, beio);
 	} else {
@@ -1272,7 +1272,7 @@ ctl_be_block_cw_dispatch_ws(struct ctl_be_block_lun *be_lun,
 	DPRINTF("entered\n");
 
 	beio = (struct ctl_be_block_io *)PRIV(io)->ptr;
-	lbalen = ARGS(beio->io);
+	lbalen = ARGS(io);
 
 	if (lbalen->flags & ~(SWS_LBDATA | SWS_UNMAP | SWS_ANCHOR | SWS_NDOB) ||
 	    (lbalen->flags & (SWS_UNMAP | SWS_ANCHOR) && be_lun->unmap == NULL)) {

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202103150301.12F31Sr8097988>