Date: Thu, 31 Aug 2006 02:22:24 +0400 From: Ruslan Ermilov <ru@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, Bruce Evans <bde@zeta.org.au> Subject: Re: cvs commit: src/sys/sys sx.h Message-ID: <20060830222224.GA12339@rambler-co.ru> In-Reply-To: <200608301811.40837.jhb@freebsd.org> References: <200608292036.k7TKaXBp044347@repoman.freebsd.org> <200608301320.33720.jhb@freebsd.org> <20060830205155.GB11411@rambler-co.ru> <200608301811.40837.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Wed, Aug 30, 2006 at 06:11:40PM -0400, John Baldwin wrote: > On Wednesday 30 August 2006 16:51, Ruslan Ermilov wrote: > > On Wed, Aug 30, 2006 at 01:20:32PM -0400, John Baldwin wrote: > > > On Wednesday 30 August 2006 05:37, Bruce Evans wrote: > > > > On Tue, 29 Aug 2006, John Baldwin wrote: > > > > > > > > > jhb 2006-08-29 20:36:33 UTC > > > > > > > > > > FreeBSD src repository > > > > > > > > > > Modified files: > > > > > sys/sys sx.h > > > > > Log: > > > > > The _sx_assert() prototype should exist if either of INVARIANTS or > > > > > INVARIANT_SUPPORT is defined so you can build a kernel with > > > > > INVARIANT_SUPPORT, but build a module with just INVARIANTS on. > > > > [...] > No. The _sx_assert() _function_ is only #ifdef INVARIANT_SUPPORT in > kern_sx.c. However, the _sx_assert() function _prototype_ is used both in > kern_sx.c when compiling, but also by consumers of the sx_assert() macro > defined in sys/sx.h. That is, the prototype is needed for both cases, 1 is > so kern_sx.c has a prototype for the function it declares, this requires > INVARIANT_SUPPORT; 2 is for all the users of sx_assert() in the tree, which > map sx_assert() to a call to _sx_assert() if INVARIANTS is defined. > OK, that's right. Sorry for the noise. Cheers, -- Ruslan Ermilov ru@FreeBSD.org FreeBSD committer [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFE9g+gqRfpzJluFF4RAo/uAJ9cJDxVlVFFHfyadykKUEcTkQ5FogCfbfla xrA0G0UreTzkhdj08+XT0CY= =LqK9 -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060830222224.GA12339>