Date: Fri, 21 Nov 2025 20:45:27 +0000 From: Shawn Webb <shawn.webb@hardenedbsd.org> To: Christos Margiolis <christos@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 9d18115ca0ab - main - sound: Retire snd_mtx* wrappers Message-ID: <tfjtmgfx6pvyypqh6ugh574u6k7vrcb43uny4nhqmx6k24qjex@es6i2jzhsra2> In-Reply-To: <69209007.369f8.65e30118@gitrepo.freebsd.org> References: <69209007.369f8.65e30118@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Fri, Nov 21, 2025 at 04:15:03PM +0000, Christos Margiolis wrote: > The branch main has been updated by christos: > > URL: https://cgit.FreeBSD.org/src/commit/?id=9d18115ca0ab0ef3f34173d4e2bdabec916d0b60 > > commit 9d18115ca0ab0ef3f34173d4e2bdabec916d0b60 > Author: Christos Margiolis <christos@FreeBSD.org> > AuthorDate: 2025-11-21 16:14:33 +0000 > Commit: Christos Margiolis <christos@FreeBSD.org> > CommitDate: 2025-11-21 16:14:47 +0000 > > sound: Retire snd_mtx* wrappers > > Do not create mutexes with snd_mtxcreate(). It doesn't provide any > value, plus it first allocates the mutex with malloc(9). Allocate > mutexes in the stack and use mtx_* functions directly instead of the > snd_mtx* wrappers. > > Sponsored by: The FreeBSD Foundation > MFC after: 1 week > Reviewed by: kib, markj > Differential Revision: https://reviews.freebsd.org/D53855 Hey Christos, I'm getting the following error on buildkernel: ==== BEGIN LOG ==== /usr/src/sys/dev/sound/pci/hdspe-pcm.c:726:3: error: call to undeclared function 'snd_mtxunlock'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration] 726 | snd_mtxunlock(sc->lock); | ^ 1 error generated. --- hdspe-pcm.o --- ==== END LOG ==== Thanks, -- Shawn Webb Cofounder / Security Engineer HardenedBSD Signal Username: shawn_webb.74 Tor-ified Signal: +1 303-901-1600 / shawn_webb_opsec.50 https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmkgz2AACgkQ/y5nonf4 4frpgg/9ENCUZj7tDCOqelOZK49s9gLmU4fOCEuj2eLLZDgCmoTNp41RfixXAd/I M57SI2ZmwGM7R5x45N4rMfhwtV906DQwsQHNh3Ezb5jlhvNPiqTHYmKMnXCcDBuI +z44RZKbjJeZGzcRp72Mo+1w3AF+JOxY7bb7ui7n9TDVScrYlN5BKU8rsX/77BO5 WV8IeNapDHTg1368hEipwptlIST1a9eaH+QSP4VR90qqlEC0+cxMx1xpbRpYKzF/ zgc7w5MbFgpO6y/iAm6kiwgszuD3UjslvRiDfL2HUzJtwM30Tm++poMi45/52qLE 4k0ew9R67XPLfGXFYl1st5hSobTpn9WDjrEc4CuU4TKT5iFeA55PP2RQzXnlvb0k kXiuOx2h35c5/QOVQ01mLo0ywaLFw4fH+DELq0rgrLBBmjc2sgczmljYyoBjo9UB YY6xcEWhQxoTP0o8iTDNHZXrbh3WO20Q5/LeInL64yOPVIujktz/nyCeu8x6wQaK nk4vZnZa1GOGWKWe4oViVK1+ezqTCtBMdALcVvMnv/NRfT1SrI4h2x7OE0y+fIru dJLQGGkBCb05ati6VA58s/dBBP4baZIFosZfRTagnB9FWjlbnMYAT5HnRffL7taA BlBE7FFratiwAxiD9SOHjj1T4Mug4UtHQw4YTXvrJuVI70rqlj8= =OViC -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?tfjtmgfx6pvyypqh6ugh574u6k7vrcb43uny4nhqmx6k24qjex>