Date: Mon, 14 Jul 2025 00:21:04 +0900 From: Olivier Certner <olce@freebsd.org> To: Mark Johnston <markj@freebsd.org> Cc: Charlie Li <vishwin@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: f1f230439fa4 - main - vfs: Initial revision of inotify Message-ID: <3224371.fEyhCgFcho@francois> In-Reply-To: <aHPIds_oMKXVBG8h@nuc> References: <202507041455.564EtqwS073424@gitrepo.freebsd.org> <2937929.UcPf6a0QyJ@francois> <aHPIds_oMKXVBG8h@nuc>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart6956069.Qb2xPn7ZBO Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8"; protected-headers="v1" From: Olivier Certner <olce@freebsd.org> To: Mark Johnston <markj@freebsd.org> Date: Mon, 14 Jul 2025 00:21:04 +0900 Message-ID: <3224371.fEyhCgFcho@francois> Organization: FreeBSD In-Reply-To: <aHPIds_oMKXVBG8h@nuc> MIME-Version: 1.0 > The store to *eofp sets eofflag, so that is not the problem. Indeed, I missed that. Checking the rest of the function, I see no problem here. > Based on the presence of "efi" as a component name in the stack trace > that Charlie provided, I suspect the problem is rather in msdosfs, but I > don't immediately see what's wrong there. Based on that, I've just read msdosfs_readdir(), and the problem could be there: """ if (dep->de_FileSize - (offset - bias) <= 0) """ because dep->de_FileSize is an *unsigned* long, and the test only passes with 'offset - bias' exactly equal to 'de_FileSize'. The assignment to `diff` in the loop above would be wrong as well. -- Olivier Certner --nextPart6956069.Qb2xPn7ZBO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCQAdFiEEmNCxHjkosai0LYIujKEwQJceJicFAmhzzuAACgkQjKEwQJce Jid25g/6ArOIvsrLTJogChCET+ovk8EsjmnPbnWgxakceyV03KX3rJ0MauoTDV01 BghhwylQolKa5i/wBV89s2p92OMgf4mgP5OqDWUwOFJZDTtNHNvMkCjEs1BVcHcl BB107XkZy4tOba2yM1sWv8GtnRuV0OojK+Myq96iouq3bf1qQKH3Z3T7VDCeo8io 8TC0HzwH1nSyiefVMpJwCSa22FmycemytZhvMjS9TeB6EpaafS8HX/ftenxT683e tWX3sPmkXOeH5Ud9XS4UFTthwVJIRbs/JpziKXkCKS5/n/Xdo6siCdEaoqAVbqCj +DsQa9RLAU2nNOmqqoxmLpkQi7TD8vkjkvrXPgGeBkkh2uoKHbZwkeWeG05Jr4sC voKMzS0+yEbpxJfAo2mMcZLXnj1lu9LE5cKG2Z97E+babtDhwpz59mUg0dvi4Dv2 0//aJC5I+vyYoW9bFmZH2EK6BNGYNkBSRFPctNPywmMcpD5k+ym4PvMFJ+I6+ue8 l3xvdn/Rw67X68l62+lt1t84ttqlVo0Z5jGWmWfjvKH/eQcewsyPJ1mROlJjUoBJ jLHpzGwKpYfaUaLpW6jtsWy5qf5FjBpjaszjHGEUMItExePcwMKWFm+OEPnFcxvs yYMovlW8vrQrhx+awimdYKnIR028g/smNrf6x5vTlPXEcuwpv2A= =96JS -----END PGP SIGNATURE----- --nextPart6956069.Qb2xPn7ZBO--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3224371.fEyhCgFcho>