Date: Sun, 22 Dec 2013 22:00:00 GMT From: Jilles Tjoelker <jilles@stack.nl> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/185077: Sync L_cuserid with MAXLOGNAME Message-ID: <201312222200.rBMM00oB037715@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/185077; it has been noted by GNATS. From: Jilles Tjoelker <jilles@stack.nl> To: bug-followup@FreeBSD.org, naddy@FreeBSD.org Cc: Subject: Re: kern/185077: Sync L_cuserid with MAXLOGNAME Date: Sun, 22 Dec 2013 22:50:44 +0100 In PR kern/185077, you wrote: > L_cuserid must match MAXLOGNAME. When MAXLOGNAME was bumped to 33 in > <sys/param.h>, L_cuserid in <stdio.h> was forgotten. > Fix: Bump L_cuserid to 33. Since cuserid() is only in libcompat which is only a static library, making this change does not break ABI. I still wonder whether it's worth it, though. What breaks if L_cuserid != MAXLOGNAME? They are different constants, so may have different values. This breakage should be weighed against the possible breakage resulting from changing things about cuserid() and L_cuserid, since they are obsolete APIs used by old crufty code. > Alternatively, for HEAD, consider completely removing cuserid(3) from > libcompat and L_cuserid with it. This is an option. It looks like cuserid() is mostly used by high-level languages to make it available to high-level language code. Parts of me, however, like the ability of compiling ancient source code, be it with -lcompat and other strange options. -- Jilles Tjoelker
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201312222200.rBMM00oB037715>