Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 1 Mar 2025 23:33:13 GMT
From:      Adrian Chadd <adrian@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 10c633ab1204 - main - ath_rate_sample: fix setting HT rates
Message-ID:  <202503012333.521NXDtY052849@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by adrian:

URL: https://cgit.FreeBSD.org/src/commit/?id=10c633ab1204e13d6fbad9f0f474229eed5fd280

commit 10c633ab1204e13d6fbad9f0f474229eed5fd280
Author:     Adrian Chadd <adrian@FreeBSD.org>
AuthorDate: 2025-03-01 22:38:53 +0000
Commit:     Adrian Chadd <adrian@FreeBSD.org>
CommitDate: 2025-03-01 23:32:56 +0000

    ath_rate_sample: fix setting HT rates
    
    ieee80211_node_set_txrate_ht_mcsrate() takes an MCS rate from 0..76,
    the high bit (IEEE80211_RATE_MCS) must not be set.
    
    This is definitely my fault - I likely didn't get to testing this
    diff when I changed it from ieee80211_node_set_txrate_dot11rate()
    just before landing.
    
    Differential Revision:  https://reviews.freebsd.org/D49197
    Reviewed by:    bz
---
 sys/dev/ath/ath_rate/sample/sample.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sys/dev/ath/ath_rate/sample/sample.c b/sys/dev/ath/ath_rate/sample/sample.c
index 8fba3c68099f..291d1ec64ed7 100644
--- a/sys/dev/ath/ath_rate/sample/sample.c
+++ b/sys/dev/ath/ath_rate/sample/sample.c
@@ -857,7 +857,8 @@ ath_rate_findrate(struct ath_softc *sc, struct ath_node *an,
 			 */
 			if (rt->info[best_rix].phy == IEEE80211_T_HT)
 				ieee80211_node_set_txrate_ht_mcsrate(
-				    &an->an_node, MCS(best_rix));
+				    &an->an_node,
+				    MCS(best_rix) & IEEE80211_RATE_VAL);
 			else
 				ieee80211_node_set_txrate_dot11rate(
 				    &an->an_node,



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202503012333.521NXDtY052849>