Date: Wed, 25 Sep 2013 18:15:33 +0400 From: Boris Samorodov <bsam@passap.ru> To: William Grzybowski <wg@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r328268 - head/www/zend-framework Message-ID: <5242F005.3010303@passap.ru> In-Reply-To: <201309251128.r8PBShhM020984@svn.freebsd.org> References: <201309251128.r8PBShhM020984@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi William and All,
just a random pickup of the commit.
25.09.2013 15:28, William Grzybowski пишет:
> .if ${PORT_OPTIONS:MDOCS}
> - @${MKDIR} ${DOCSDIR}
> - ${INSTALL_DATA} ${PORTDOCS:S,^,${WRKSRC}/,} ${DOCSDIR}/
> + @${MKDIR} ${STAGEDIR}${DOCSDIR}
> + ${INSTALL_DATA} ${PORTDOCS:S,^,${WRKSRC}/,} ${STAGEDIR}${DOCSDIR}/
> .endif
If I understand staging correctly, those ".if ..." and ".endif" lines
may be removed as well:
a) with staging the role of pkg-plist has changed greatly. Before
staging an ordinary (with just a filename) line at pkg-plist meant
that a file _should_ be installed. With staging that line defines
that the file _will_ be installed (i.e. pkg-plist is the source
of what to install);
b) real install to PREFIX will not contain all files installed at
STAGEDIR but only those listed at pkg-plist modulo %%VARIOUS_DEFINES%%.
So if PORT_OPTIONS:MDOCS is not defined those files with %%PORTDOCS%%
will not be installed to the system (however they will appear at the
STAGEDIR).
In short: if you omit those if-endif checks then PORTDOCS would be
always copied to STAGEDIR. But they would be installed to real system
only if PORT_OPTIONS:MDOCS is defined.
Disclaimer: I can't say anything about system performance impact of
having/not having those checks at a Makefile.
So in the end it may be just a matter of taste... until we have a
policy on this.
--
WBR, Boris Samorodov (bsam)
FreeBSD Committer, http://www.FreeBSD.org The Power To Serve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5242F005.3010303>