Date: Fri, 21 Nov 2025 20:46:18 +0000 From: Shawn Webb <shawn.webb@hardenedbsd.org> To: Christos Margiolis <christos@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 9d18115ca0ab - main - sound: Retire snd_mtx* wrappers Message-ID: <zc4flp64tzpveyezhojzbbgppvlvfiqyhygljy3t3xdtufxsyv@46knkawsq5kx> In-Reply-To: <tfjtmgfx6pvyypqh6ugh574u6k7vrcb43uny4nhqmx6k24qjex@es6i2jzhsra2> References: <69209007.369f8.65e30118@gitrepo.freebsd.org> <tfjtmgfx6pvyypqh6ugh574u6k7vrcb43uny4nhqmx6k24qjex@es6i2jzhsra2>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Fri, Nov 21, 2025 at 08:45:27PM +0000, Shawn Webb wrote: > On Fri, Nov 21, 2025 at 04:15:03PM +0000, Christos Margiolis wrote: > > The branch main has been updated by christos: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=9d18115ca0ab0ef3f34173d4e2bdabec916d0b60 > > > > commit 9d18115ca0ab0ef3f34173d4e2bdabec916d0b60 > > Author: Christos Margiolis <christos@FreeBSD.org> > > AuthorDate: 2025-11-21 16:14:33 +0000 > > Commit: Christos Margiolis <christos@FreeBSD.org> > > CommitDate: 2025-11-21 16:14:47 +0000 > > > > sound: Retire snd_mtx* wrappers > > > > Do not create mutexes with snd_mtxcreate(). It doesn't provide any > > value, plus it first allocates the mutex with malloc(9). Allocate > > mutexes in the stack and use mtx_* functions directly instead of the > > snd_mtx* wrappers. > > > > Sponsored by: The FreeBSD Foundation > > MFC after: 1 week > > Reviewed by: kib, markj > > Differential Revision: https://reviews.freebsd.org/D53855 > > Hey Christos, > > I'm getting the following error on buildkernel: > > ==== BEGIN LOG ==== > /usr/src/sys/dev/sound/pci/hdspe-pcm.c:726:3: error: call to undeclared function 'snd_mtxunlock'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration] > 726 | snd_mtxunlock(sc->lock); > | ^ > 1 error generated. > --- hdspe-pcm.o --- > ==== END LOG ==== Never mind. I didn't realize HardenedBSD had a change to that file. Sorry for the noise! -- Shawn Webb Cofounder / Security Engineer HardenedBSD Signal Username: shawn_webb.74 Tor-ified Signal: +1 303-901-1600 / shawn_webb_opsec.50 https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmkgz5oACgkQ/y5nonf4 4fq0PQ/9Gy5dzYOscqplx0tQKfutUcCFv0bSuKigaSMMl9Y8ToyK+oZgKMFJc62F 6AA4n2vaEK5GBxe9vr/jDyjVKM43oAHuXaK8nMYdZUZW2N/xRN+sesqBB+WfCO1y Xsuz4tKBQ7F4y21TX0eegjK6rixPNhPr2r29KhQz9Cg7O3H7Hc/RhifXIl6vKYN5 HYpbIgYuNcoS/kg2/HU8BhrksofQwLB1Ha2LBN57R3FLhFjva+Btlwb0Ic5P6JHQ bpG+pOdxhV90eJBbRpgZRwE1wlnjdEtHuGcDRidFlEXeb/J2mekMpLyiLmjZ82WK kT2zVO+AGGrHs+nPAoZLURGrvGOLo7MXCDbsuw1F4R5r982XByJVW9oqYKHMoUyd E/o1qBa5vylnUQtYfvWKlM7qj90ny5VfrPXfmXzmSp2S5sJ9GJu1dJRmeHEyow44 zyepW5lzoqB5gOvf1CojpTAXD3bFZWd4qBSOuvoRv74/5LY+kGkzm9vOtUOpoGbX 7aB7h3nqu7iub762hJQFdt3EoqBRmlRr/X0EMszqT0DDnUke/kj1DTrT6nET/23M X6Oi8YHxfjBvE/Tmq1tTPfh22eDxz8PAVJ3XpJS8fC9syj5fhisOr0qBzS/xblWd yUOzq5unzcIkFQ5pXG8L+bbcV+GLqSmeRjiUTMGDb6iLV5iBy80= =1t/x -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?zc4flp64tzpveyezhojzbbgppvlvfiqyhygljy3t3xdtufxsyv>