Date: Mon, 4 Feb 2019 12:13:50 -0800 From: Enji Cooper <yaneurabeya@gmail.com> To: rgrimes@freebsd.org Cc: Enji Cooper <ngie@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r343751 - head/lib/libc/tests/sys Message-ID: <3CF9638D-9799-4176-97C7-A17A12B0DEC4@gmail.com> In-Reply-To: <201902042009.x14K9vIJ037929@pdx.rh.CN85.dnsmgr.net> References: <201902042009.x14K9vIJ037929@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Feb 4, 2019, at 12:09 PM, Rodney W. Grimes <freebsd@pdx.rh.CN85.dnsmgr.net> wrote: > >> Author: ngie >> Date: Mon Feb 4 19:12:45 2019 >> New Revision: 343751 >> URL: https://svnweb.freebsd.org/changeset/base/343751 >> >> Log: >> Avoid the DNS lookup for "localhost" >> >> ci.FreeBSD.org does not have access to a DNS resolver/network (unlike my test >> VM), so in order for the test to pass on the host, it needs to avoid the DNS >> lookup by using the numeric host address representation. > > If it can not get to a resolver, it should be falling back to > /etc/hosts whch does have the correct entries for localhost. Please continue this thread of discussion on Phabricator. This was already discussed sort of there. As I said before (when it was commented on by @emaste): >> In D19026#407184, @emaste wrote: >> I don't object to this patch but shouldn't we be able to prevent any DNS use via nsswitch.conf? >> That would require everyone make a corresponding change to prevent any DNS use when running this test. > It's better to focus on what needs to be tested, instead of what's nice to test by side-effect. There are other tests that exercise DNS lookups (which currently fail after a long timeout due to a lacking external connection). > This is a quick hack to set this test on a working path. The right path is the suggestion @asomers provided in the previous review, to use if_tap. Thanks -Enji
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3CF9638D-9799-4176-97C7-A17A12B0DEC4>