Date: Sun, 10 Feb 2019 00:38:24 -0800 From: Conrad Meyer <cem@freebsd.org> To: Michael Tuexen <tuexen@fh-muenster.de> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r343746 - head/sys/conf Message-ID: <CAG6CVpWJt%2BPGjPLFMC0Y3RhWfcUgygvPr%2BGVn2ZK-nDJ=iD=1g@mail.gmail.com> In-Reply-To: <6436189F-037C-4AB0-A59C-BE68A781FB30@fh-muenster.de> References: <201902041655.x14GtOIr046072@repo.freebsd.org> <CAG6CVpUqFp-qAYoD0CSAz%2BGZf_gcchQ0BswgxhRcYq88VO1sow@mail.gmail.com> <6436189F-037C-4AB0-A59C-BE68A781FB30@fh-muenster.de>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Michael, I don't know. You can 'pkg install amd64-xtoolchain-gcc' and 'make buildkernel KERNCONF=3DGENERIC CROSS_TOOLCHAIN=3Damd64-gcc' if you're interested in trying it. (I'm not sure enabling coverage globally in GENERIC is appropriate even if it did not break boot =E2=80=94 it's usually expensive, and while GENERIC is already slow, that doesn't mean we can just make it 10x slower.) Best, Conrad On Sun, Feb 10, 2019 at 12:03 AM Michael Tuexen <tuexen@fh-muenster.de> wro= te: > > > On 10. Feb 2019, at 08:50, Conrad Meyer <cem@FreeBSD.org> wrote: > > > > Hi Andrew, > > > > This makes it compile, but instead of a build failure the kernel is > > broken hard at runtime in early boot with GCC < 8.1. E.g., > > amd64-xtoolchain-gcc standard cross-toolchain is still on GCC 6.4.0. > > > > HEAD GENERIC has been broken in one form or another for xtoolchain GCC > > since r343713 (Feb 3), so I'm going to go ahead and turn this option > > off in GENERIC. Feel free to reenable when you've tested that it > > works. > Hi Conrad, > > does https://reviews.freebsd.org/D19135 fix the issue you are observing? > > Best regards > Michael > > > > Best, > > Conrad > > > > On Mon, Feb 4, 2019 at 8:55 AM Andrew Turner <andrew@freebsd.org> wrote= : > >> > >> Author: andrew > >> Date: Mon Feb 4 16:55:24 2019 > >> New Revision: 343746 > >> URL: https://svnweb.freebsd.org/changeset/base/343746 > >> > >> Log: > >> Only enable trace-cmp on Clang and modern GCC. > >> > >> It's was only added to GCC 8.1 so don't try to enable it for earlier > >> releases. > >> > >> Reported by: lwhsu > >> Sponsored by: DARPA, AFRL > >> > >> Modified: > >> head/sys/conf/files > >> head/sys/conf/kern.pre.mk > >> > >> Modified: head/sys/conf/files > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > >> --- head/sys/conf/files Mon Feb 4 16:13:41 2019 (r343745) > >> +++ head/sys/conf/files Mon Feb 4 16:55:24 2019 (r343746) > >> @@ -3808,7 +3808,7 @@ kern/kern_idle.c standard > >> kern/kern_intr.c standard > >> kern/kern_jail.c standard > >> kern/kern_kcov.c optional kcov \ > >> - compile-with "${NORMAL_C} -fno-sanitize-coverage=3D= trace-pc,trace-cmp" > >> + compile-with "${NORMAL_C} -fno-sanitize=3Dall" > >> kern/kern_khelp.c standard > >> kern/kern_kthread.c standard > >> kern/kern_ktr.c optional ktr > >> > >> Modified: head/sys/conf/kern.pre.mk > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > >> --- head/sys/conf/kern.pre.mk Mon Feb 4 16:13:41 2019 (r3437= 45) > >> +++ head/sys/conf/kern.pre.mk Mon Feb 4 16:55:24 2019 (r3437= 46) > >> @@ -120,7 +120,12 @@ SAN_CFLAGS+=3D -fsanitize=3Dundefined > >> > >> COVERAGE_ENABLED!=3D grep COVERAGE opt_global.h || true ; echo > >> .if !empty(COVERAGE_ENABLED) > >> +.if ${COMPILER_TYPE} =3D=3D "clang" || \ > >> + (${COMPILER_TYPE} =3D=3D "gcc" && ${COMPILER_VERSION} >=3D 80100) > >> SAN_CFLAGS+=3D -fsanitize-coverage=3Dtrace-pc,trace-cmp > >> +.else > >> +SAN_CFLAGS+=3D -fsanitize-coverage=3Dtrace-pc > >> +.endif > >> .endif > >> > >> CFLAGS+=3D ${SAN_CFLAGS} > >> > > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpWJt%2BPGjPLFMC0Y3RhWfcUgygvPr%2BGVn2ZK-nDJ=iD=1g>