Date: Mon, 2 Oct 2023 20:25:33 -0700 From: Colin Percival <cperciva@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 7494fb6b7d80 - main - EC2: Flavour existing AMIs as "base" Message-ID: <226ab4a0-f6c8-d5c1-e564-bde9cb4cd797@freebsd.org> In-Reply-To: <ZRZmBtCDrgHpwqEF@FreeBSD.org> References: <202309282218.38SMIqGH056845@gitrepo.freebsd.org> <ZRZmBtCDrgHpwqEF@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 9/28/23 22:52, Alexey Dokuchaev wrote: > On Thu, Sep 28, 2023 at 10:18:52PM +0000, Colin Percival wrote: >> commit 7494fb6b7d809257d4eb9eff06ce226143f27add >> >> EC2: Flavour existing AMIs as "base" > > I think it should be "flavor" since FreeBSD prefers American spelling. I understand that's a policy for FreeBSD documentation, but I'm not aware of any such policy for the FreeBSD src tree. And indeed there are thousands of behaviours, colours, and flavours in the tree, including "colours offered by the original IBM PC Color Graphics Adapter". >> @@ -31,6 +31,7 @@ BASIC-CI_DESC= Image for CI >> EC2_FORMAT= raw >> EC2_FSLIST= ufs zfs >> EC2_DESC= Amazon EC2 image >> +EC2_FLAVOURS= BASE > > Since other nearby values (format, filesystems) are lowercase, perhaps > it makes sense to say EC2_FLAVORS=base and :tu it when needed in the > code to keep declarations consistent and tidy. We already had "VIRTUALBOX" and "VMWARE" flavours of Vagrant (and these are all flavours of upper-cased EC2/GCE/OCI/VAGRANT/etc) so I figured that I would follow the example of being, err, consistently inconsistent. I agree that having everything in lower case would make sense though. -- Colin Percival FreeBSD Deputy Release Engineer & EC2 platform maintainer Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?226ab4a0-f6c8-d5c1-e564-bde9cb4cd797>