Date: Sun, 7 Oct 2012 16:31:33 +1100 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Marcel Moolenaar <marcel@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r241298 - in head: . gnu/usr.bin/cc/cc_int gnu/usr.bin/cc/include kerberos5 kerberos5/tools/asn1_compile kerberos5/tools/slc lib/clang/include share/mk tools/build/make_check usr.sbin/c... Message-ID: <20121007161440.C7605@besplex.bde.org> In-Reply-To: <201210062001.q96K16Or030755@svn.freebsd.org> References: <201210062001.q96K16Or030755@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 6 Oct 2012, Marcel Moolenaar wrote:
> Log:
> Add support for bmake. This includes:
> ....
> Modified: head/share/mk/bsd.dep.mk
> ==============================================================================
> --- head/share/mk/bsd.dep.mk Sat Oct 6 19:57:27 2012 (r241297)
> +++ head/share/mk/bsd.dep.mk Sat Oct 6 20:01:05 2012 (r241298)
> @@ -102,8 +102,8 @@ ${_YC} y.tab.h: ${_YSRC}
> CLEANFILES+= y.tab.c y.tab.h
> .elif !empty(YFLAGS:M-d)
> .for _YH in ${_YC:R}.h
> -.ORDER: ${_YC} ${_YH}
> -${_YC} ${_YH}: ${_YSRC}
> +${_YH}: ${_YC}
> +${_YC}: ${_YSRC}
> ${YACC} ${YFLAGS} -o ${_YC} ${.ALLSRC}
> SRCS+= ${_YH}
> CLEANFILES+= ${_YH}
This is broken. Yacc headers don't depend on generated yacc .c files.
Now there is only a null rule to create the headers. One broken case
is when the header somehow gets deleted. It bcomes out of date, but
running make to update it only runs the null rule, so it remains
nonexistent.
Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121007161440.C7605>