Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 18 Aug 2014 00:45:52 +0200
From:      Dimitry Andric <dim@FreeBSD.org>
To:        Alexey Dokuchaev <danfe@FreeBSD.org>
Cc:        svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-9@freebsd.org
Subject:   Re: svn commit: r270099 - in stable: 10/contrib/gcc/config/i386 9/contrib/gcc/config/i386
Message-ID:  <9181921C-43BB-48C9-B63D-7C6F99D7A763@FreeBSD.org>
In-Reply-To: <20140817134509.GA47327@FreeBSD.org>
References:  <201408171308.s7HD8Fnh099147@svn.freebsd.org> <20140817131942.GA38672@FreeBSD.org> <8CA269F6-BCD2-4E78-947F-682214367F36@FreeBSD.org> <20140817134509.GA47327@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--Apple-Mail=_C83297FD-146A-46B2-9B6B-8A9FE967E121
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii

On 17 Aug 2014, at 15:45, Alexey Dokuchaev <danfe@FreeBSD.org> wrote:
> On Sun, Aug 17, 2014 at 03:29:42PM +0200, Dimitry Andric wrote:
>> In principle it is applicable, but the same file also has other changes
>> in head which were not MFCd, so just MFCing this one commit does not
>> make much sense.  For example, the earlier cast fixes were part of a
>> much larger commit by Pedro Giffuni, adding "experimental support for
>> amdfam10/barcelona CPUs":
>> 
>> http://svnweb.freebsd.org/base?view=revision&revision=251212
> 
> I'm running my stable/8 with Pedro's patches applied, including r251212,
> no problems so far (although I don't have recent AMD CPUs to play with).
> 
>> Does it still make sense to backport such experimental changes to an old
>> stable branch?  Of course I could split off just the changes to
>> emmintrin.h, and leave the others out, but then we would have a partial
>> MFC.  I'm not sure if that is the usual way of doing things...
> 
> Understood.  My goal here is to try to keep stable/8 as alive as possible,
> since I plan to keep using it beyond its official EOL.  Hence, when I see
> fixes that potentially help ports to be buildable on it I'd usually ask if
> they can be MFCed (when it's easy enough to do).

Can you please try this diff [1], which merges most of the stable/9 gcc
changes to stable/8?  I've ran it through a make universe, and the only
failure I got was with the amd64 XENHVM kernel:

amd64 XENHVM kernel failed, check _.amd64.XENHVM for deatils

but I don't know if this is an expected failure or not.  Tinderbox seems
to have other trouble with its stable/8 builds.  The actual error is:

In file included from sys/sys/param.h:86,
                 from sys/compat/ia32/ia32_genassym.c:6:
sys/sys/types.h:44:28: error: machine/endian.h: No such file or directory

I didn't test any ports yet, though.

-Dimitry

[1] http://www.andric.com/freebsd/sync-stable8-gcc-with-stable9-1.diff.xz


--Apple-Mail=_C83297FD-146A-46B2-9B6B-8A9FE967E121
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.22 (Darwin)

iEYEARECAAYFAlPxMMUACgkQsF6jCi4glqOzTgCfSWlos/pA4l9XzksU4X659yf4
IPYAoMlpUIvUERHn5T2JgSwV3872cXKO
=uqz+
-----END PGP SIGNATURE-----

--Apple-Mail=_C83297FD-146A-46B2-9B6B-8A9FE967E121--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9181921C-43BB-48C9-B63D-7C6F99D7A763>