Date: Fri, 30 Nov 2018 07:23:01 -0700 From: Warner Losh <imp@bsdimp.com> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Eugene Grosbein <eugen@grosbein.net>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, Steven Hartland <steven.hartland@multiplay.co.uk>, svn-src-head@freebsd.org, Cy Schubert <Cy.Schubert@cschubert.com> Subject: Re: svn: head/usr.bin: . trim Message-ID: <CANCZdfpEgOrPDbwe%2BnKAYdi6wo-=odpcuUnj4fjYrsUeTC5Xpw@mail.gmail.com> In-Reply-To: <20181130125645.GA97463@FreeBSD.org> References: <20181130011713.42B641D27@spqr.komquats.com> <0e233c0c-6c80-4618-9618-48162362a849@multiplay.co.uk> <20181130084955.o4loxtuswdsvzksy@ivaldir.net> <20181130105714.GA84052@FreeBSD.org> <15e4f063-d081-9c38-be3e-44bc622cc50e@freebsd.org> <20181130113422.GA14353@FreeBSD.org> <df7ba408-2caf-92fb-8083-26bad4055bb3@freebsd.org> <20181130115515.GA28531@FreeBSD.org> <a77e429a-7fa3-2b87-044d-260be380d631@grosbein.net> <20181130125645.GA97463@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Nov 30, 2018 at 5:57 AM Alexey Dokuchaev <danfe@freebsd.org> wrote: > On Fri, Nov 30, 2018 at 07:27:46PM +0700, Eugene Grosbein wrote: > > 30.11.2018 18:55, Alexey Dokuchaev wrote: > > > > >>> Another point: the manpage says, "It is only relevant for flash based > > >>> storage devices that use wear-leveling algorithms", which is an > argument > > >>> against generic "trim". I would mind less of it would be called > ftrim(8) > > >>> or ssd_trim(8) or flash_trim(8), but still prefer Maxim's approach. > > > > [skip] > > > > > Yes, I understand you. Like I've said, a little more > flash-media-related > > > name would perhaps be more appropriate for such an utility. > > > > This excludes virtio_blk and ZFS. Perhaps, manpage should be corrected > > as quoted phrase has been taken from news -E description as is. > > How about mtrim(8) or media_trim(8)? I vaguely when back in times misc/mc > was installed as bin/midc because some commercial Unix implementation had > "mc" as a "media copy" command or something like that. > We should just put it in dd and remove this experiment. Both of these suggested names are horrible. They are too specific. And the notion that trim is too generic may have some merit, but the cure is worse than the disease. So I'm back to my point: we should just put it into dd and move on with our lives. It's really the right place for it. Why? Because then we can have 'dd if=image of=/dev/foo conf=sparse,erase' and it will erase the bits of the drive that are all 0's. We won't have to resort to weird hacks to make most of them trimmed. While this works only on media where trim is persistently 0's, that describes all modern flash media and most (all?) of the virtualization / thin storage scenarios I'm aware of. You can't do that with the current utility, at least not w/o a lot of effort. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfpEgOrPDbwe%2BnKAYdi6wo-=odpcuUnj4fjYrsUeTC5Xpw>