Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 23 Mar 2002 15:29:58 -0700 (MST)
From:      "M. Warner Losh" <imp@village.org>
To:        obrien@FreeBSD.org
Cc:        bde@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/sys bio.h conf.h disklabel.h diskslice.h event.h file.h filedesc.h libkern.h malloc.h mount.h msgbuf.h protosw.h socketvar.h sysent.h systm.h
Message-ID:  <20020323.152958.99178604.imp@village.org>
In-Reply-To: <20020323123015.A861@dragon.nuxi.com>
References:  <200203230846.g2N8kqk91906@freefall.freebsd.org> <20020323123015.A861@dragon.nuxi.com>

next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20020323123015.A861@dragon.nuxi.com>
            "David O'Brien" <obrien@FreeBSD.org> writes:
: On Sat, Mar 23, 2002 at 12:46:52AM -0800, Bruce Evans wrote:
: >   Modified files:
: >     sys/sys              bio.h conf.h disklabel.h diskslice.h 
: >                          event.h file.h filedesc.h libkern.h 
: >                          malloc.h mount.h msgbuf.h protosw.h 
: >                          socketvar.h sysent.h systm.h 
: >   Log:
: >   Fixed some style bugs in the removal of __P(()).  The main ones were
: >   not removing tabs before "__P((", and not outdenting continuation lines
: >   to preserve non-KNF lining up of code with parentheses.  Switch to KNF
: >   formatting and/or rewrap the whole prototype in some cases.
: 
: According to style(9) you have not KNF'ed the prototypes.
: Applicable example:
: 
: static char	*function(int _arg, const char *_arg2, struct foo *_arg3,
: 		    struct bar *_arg4);

Is this because he left some functions with "emacs-style" indentation:

static char	*function(int _arg, const char *_arg2, struct foo *_arg3,
			  struct bar *_arg4);

Or some other reason?  There are so many files that it is hard to know
what you are talking about for sure...

Warner

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020323.152958.99178604.imp>