Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 06 Sep 2022 19:09:24 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 229230] newvers falsely appends "-dirty" to hash when building in a git tree with no content changes
Message-ID:  <bug-229230-227-aR8bANQYuE@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-229230-227@https.bugs.freebsd.org/bugzilla/>
References:  <bug-229230-227@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D229230

--- Comment #3 from commit-hook@FreeBSD.org ---
A commit in branch stable/12 references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=3Db67bd2859d7d757ee9ceb8269a5790f4f=
1091be5

commit b67bd2859d7d757ee9ceb8269a5790f4f1091be5
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2018-11-02 21:20:46 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2022-09-06 17:15:05 +0000

    newvers.sh: fix git false positive -dirty tag

    Assuming that any output from `git diff-index --name-only` implies
    changes in the working tree results in false positives: files with
    metadata, but not content, changes are also listed.

    Check that content differences exist before adding the -dirty tag to
    the git hash.

    PR:             229230
    Reviewed by:    markj
    Sponsored by:   The FreeBSD Foundation
    Differential Revision:  https://reviews.freebsd.org/D15968

    (cherry picked from commit 50b53a8dc35f38ab6920dd83409541e875d01551)
    (cherry picked from commit 5186028dc4a2a74d007fa65857667efb2742eaea)

 sys/conf/newvers.sh | 31 +++++++++++++++++++++++++++++--
 1 file changed, 29 insertions(+), 2 deletions(-)

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-229230-227-aR8bANQYuE>