Date: Thu, 13 Aug 2009 09:36:09 +0100 (BST) From: Robert Watson <rwatson@FreeBSD.org> To: Nick Hibma <n_hibma@FreeBSD.org> Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-7@freebsd.org Subject: Re: svn commit: r196171 - stable/7/sys/netsmb Message-ID: <alpine.BSF.2.00.0908130934220.62111@fledge.watson.org> In-Reply-To: <200908130831.n7D8VF7U093805@svn.freebsd.org> References: <200908130831.n7D8VF7U093805@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 13 Aug 2009, Nick Hibma wrote:
> Silence this module.
I can't help but notice you're committing changes to a stable branch without
first making them in head. For the USB stack, where there's a different
implementation between head and stable/7, that's fine. For code that's
shared, it's really not fine. Please stop.
Robert N M Watson
Computer Laboratory
University of Cambridge
>
> Modified:
> stable/7/sys/netsmb/smb_dev.c
>
> Modified: stable/7/sys/netsmb/smb_dev.c
> ==============================================================================
> --- stable/7/sys/netsmb/smb_dev.c Thu Aug 13 08:24:58 2009 (r196170)
> +++ stable/7/sys/netsmb/smb_dev.c Thu Aug 13 08:31:15 2009 (r196171)
> @@ -341,7 +341,6 @@ nsmb_dev_load(module_t mod, int cmd, voi
> break;
> }
> nsmb_dev_tag = EVENTHANDLER_REGISTER(dev_clone, nsmb_dev_clone, 0, 1000);
> - printf("netsmb_dev: loaded\n");
> break;
> case MOD_UNLOAD:
> smb_iod_done();
> @@ -351,7 +350,6 @@ nsmb_dev_load(module_t mod, int cmd, voi
> EVENTHANDLER_DEREGISTER(dev_clone, nsmb_dev_tag);
> drain_dev_clone_events();
> destroy_dev_drain(&nsmb_cdevsw);
> - printf("netsmb_dev: unloaded\n");
> break;
> default:
> error = EINVAL;
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.0908130934220.62111>