Date: Tue, 30 Jun 2015 11:19:30 +0800 From: Julian Elischer <julian@freebsd.org> To: Ed Schouten <ed@nuxi.nl>, Konstantin Belousov <kib@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r284887 - in head/sys: kern sys ufs/ffs Message-ID: <55920AC2.3060809@freebsd.org> In-Reply-To: <CABh_MKk-48D4FP-BgNLxvVuw4=3_YKnTX-5kSdL7LSAjCVCNOg@mail.gmail.com> References: <201506270944.t5R9iEjO053344@svn.freebsd.org> <CABh_MKk-48D4FP-BgNLxvVuw4=3_YKnTX-5kSdL7LSAjCVCNOg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 6/29/15 8:19 PM, Ed Schouten wrote:
> Hi Kostik,
>
> 2015-06-27 11:44 GMT+02:00 Konstantin Belousov <kib@freebsd.org>:
>> @@ -2056,6 +2072,8 @@ ffs_bufwrite(struct buf *bp)
>> if (bp->b_vflags & BV_BKGRDINPROG)
>> panic("bufwrite: still writing");
>> }
>> + if ((bp->b_vflags & BV_BKGRDERR) != 0)
>> + bp->b_vflags &= ~BV_BKGRDERR;
>> BO_UNLOCK(bp->b_bufobj);
>>
>> /*
> This if-statement could be removed, right? The bit could just be
> cleared unconditionally.
true but it replaces a read and write with just a read in the case of
no change.
> Best regards,
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55920AC2.3060809>