Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 20 Dec 2010 15:34:05 +0000
From:      Bruce Cran <bruce@cran.org.uk>
To:        Anonymous <swell.k@gmail.com>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, "David E. O'Brien" <obrien@FreeBSD.org>
Subject:   Re: svn commit: r212770 - head/usr.bin/script
Message-ID:  <20101220153405.00005692@unknown>
In-Reply-To: <86tyi8law3.fsf@gmail.com>
References:  <201009162231.o8GMV3Ov009118__30279.1559639902$1284676285$gmane$org@svn.freebsd.org> <86tyi8law3.fsf@gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 20 Dec 2010 18:30:36 +0300
Anonymous <swell.k@gmail.com> wrote:

> "David E. O'Brien" <obrien@FreeBSD.org> writes:
> > +	if (av[0])
> > +		for (k = 0 ; av[k] ; ++k)
> > +			fprintf(fscript, "%s%s", k ? " " : "",
> > av[k]);
> > +		fprintf(fscript, "\r\n");
> > +
> 
> An indent bug? 2nd fprintf() call is not under if(av[0]).

But the 2nd printf() call isn't in the scope of the if statement.
Personally I prefer braces if a statement is longer than 1 line, even
if not strictly required.

-- 
Bruce Cran



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101220153405.00005692>