Date: Tue, 2 Aug 2005 15:19:53 +0900 From: YONETANI Tomokazu <qhwt+fbsd@les.ath.cx> To: diz@linuxpowered.com Cc: freebsd-hackers@freebsd.org Subject: Re: [patch] rc.d/tmp (silly mkdir usage) Message-ID: <20050802061953.GA964@les.ath.cx> In-Reply-To: <51934.68.95.232.238.1122957425.squirrel@68.95.232.238> References: <51934.68.95.232.238.1122957425.squirrel@68.95.232.238>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Aug 01, 2005 at 11:37:05PM -0500, diz@linuxpowered.com wrote: > I'm sorry for the previous patch, so here is at least one item that really > bugs me that isn't obfuscation. In short, I don't see any reason to fork > some process to simply "touch" a file (is a filesystem writable) when > built-in shell i/o does this: > > --- /etc/rc.d/tmp.orig Mon Aug 1 23:20:24 2005 > +++ /etc/rc.d/tmp Mon Aug 1 23:22:07 2005 > @@ -48,8 +48,8 @@ > [Nn][Oo]) > ;; > *) > - if (/bin/mkdir -p /tmp/.diskless 2> /dev/null); then > - rmdir /tmp/.diskless > + if ( > /tmp/.diskless 2> /dev/null); then > + rm /tmp/.diskless > else > if [ -h /tmp ]; then > echo "*** /tmp is a symlink to a non-writable area!" > Try this as a non-root user, reboot the system and see what happens: $ ln -s /bin/rm /tmp/.diskless
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050802061953.GA964>