Date: Sun, 7 Apr 2002 03:20:09 +0000 From: "J. Mallett" <jmallett@FreeBSD.org> To: "J. Mallett" <jmallett@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/sed process.c Message-ID: <20020407032009.A28997@FreeBSD.ORG> In-Reply-To: <200204070229.g372Tui51878@freefall.freebsd.org> References: <200204070229.g372Tui51878@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Apr 06, 2002 at 06:29:56PM -0800, J. Mallett wrote: > jmallett 2002/04/06 18:29:56 PST > > Modified files: > usr.bin/sed process.c > Log: > Fix sed(1) in the case where a last line is specified and hold space is not > specified, and then the first part of the pattern space is deleted, when > there are two or more input lines, as this results in subtraction of one from > an unsigned integral value of '0'. That bogus value is used in one case > for a loop (that will run far too many times in this case) and a function to > search for a value within a specified range of memory, however now the range > of memory is obscenely large and a segmentation fault will occur. This is > fixed by checking for and appropriately handling a nil pattern space as if > the specified search in memory failed, as indeed it obviously will with nil > pattern space. > > Submitted by: Tim J. Robbins <tim@robbins.dropbear.id.au> > PR: bin/34813 > Reviewed by: mike > MFC after: 1 day This was a lie. I had thought since this change had been tested pretty much verbatim in other BSD's it'd be okay to short MFC, since it fixed a bug in a known-good way, but nevertheless, it's been pointed out to me I should wait a little longer, so I'll wake 3 days I suppose. Hope nobody had an anneurism over it! Sorry for the confusion. -- jmallett@FreeBSD.org | C, MIPS, POSIX, UNIX, BSD, IRC Geek. http://www.FreeBSD.org | The Power to Serve "We all need mirrors to remind ourselves who we are -- I'm no different." To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020407032009.A28997>