Date: Tue, 17 Apr 2018 00:02:04 +0000 From: Rick Macklem <rmacklem@uoguelph.ca> To: Julian Elischer <julian@freebsd.org>, Konstantin Belousov <kostikbel@gmail.com>, Andriy Gapon <avg@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r332559 - head/usr.sbin/mountd Message-ID: <YQBPR0101MB104243594E51285F229BC11FDDB00@YQBPR0101MB1042.CANPRD01.PROD.OUTLOOK.COM>
next in thread | raw e-mail | index | archive | help
I wrote:
>Julian Elischer wrote:
>>On 16/4/18 6:56 pm, Konstantin Belousov wrote:
>[stuff snipped]
>>>> + ngroups =3D3D XU_NGROUPS + 1;
>>> Why XU_NGROUPS and not the value of sysctl("kern.ngroups") ?
>>valid question.. because that is how many are allocated?
>>it was a "minimally invasive patch".. whoever used XU_NGROUPS before
>>should have fixed it.
>>Having said that, thanks for drawing out attention to it.. will
>>probably fix.
>16 is the limit specified in the RFCs for Sun RPC, so that is the "on the =
wire" limit.
>I haven't looked at the code. It might make sense to handle more here and =
then
>set the limit at 16 after getting rid of duplicates, but I have no idea if=
=3D
>it matters?
>
>rick
Correcting my own post. Now that I've looked at the code, this doesn't go o=
n
the wire. It does go in the exports structure, which means that this struct=
ure
would have to be revised (along with the syscall and VOP calls and the kern=
el
code that uses it). These credentials are for the "maproot/mapall" export
option and revising the export structure seems like quite a bit of work for=
this
case. (Until revised XU_NGROUPS is the correct value to set it to, since th=
ere
is a "struct xucred" in the exports structure.)
Since Julian Elischer has been emailing me about adding a "fsid" export opt=
ion
which allows /etc/exports to set the FSID of the exported fs (which would a=
lso
need to go in the exports structure), it might be about time to rev. the ex=
ports
structure?
rick=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YQBPR0101MB104243594E51285F229BC11FDDB00>