Date: Wed, 28 Jan 2015 08:31:22 +0000 From: "arybchik (Andrew Rybchenko)" <phabric-noreply@FreeBSD.org> To: freebsd-net@freebsd.org Subject: [Differential] [Request, 20 lines] D1699: sfxge: Remove extra cache-line alignment and reorder sfxge_evq_t Message-ID: <differential-rev-PHID-DREV-psjlcxuqy25vn4fjrwlb-req@FreeBSD.org>
next in thread | raw e-mail | index | archive | help
arybchik created this revision. arybchik added a reviewer: gnn. arybchik added a subscriber: freebsd-net. REVISION SUMMARY Remove the first member alignment to cacheline since it is nop. Use __aligned() for the whole structure to make sure that the structure size is cacheline aligned. Remove lock alignment to make the structure smaller and fit all members used on event queue processing into one cacheline (128 bytes) on x86-64. The lock is obtained as well from different context when event queue statistics are retrived from sysctl context, but it is infrequent. Reorder members to avoid padding and go in usage order on event processing. BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D1699 AFFECTED FILES sys/dev/sfxge/sfxge.h To: arybchik, gnn Cc: freebsd-net
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?differential-rev-PHID-DREV-psjlcxuqy25vn4fjrwlb-req>