Date: Tue, 21 Oct 2008 14:04:44 -0700 From: Alfred Perlstein <alfred@freebsd.org> To: Norbert Koch <nkoch@demig.de> Cc: freebsd-hackers@freebsd.org, freebsd-threads@freebsd.org Subject: Re: 'libc_r: enter/leave_cancellation_point() Message-ID: <20081021210444.GB22503@elvis.mu.org> In-Reply-To: <48FD88B1.3050106@demig.de> References: <48FD88B1.3050106@demig.de>
next in thread | previous in thread | raw e-mail | index | archive | help
Hey Norbert, this is probably a bug, but might not be addressed
because libc_r is not really supported any longer.
Someone may pick it up, but I'm uncertain of that.
* Norbert Koch <nkoch@demig.de> [081021 01:32] wrote:
> Hello,
>
> I was just inspecting libc_r for trying to understand
> some things and found this:
>
> <-------------------------
>
> --- src/lib/libc_r/uthread/uthread_cond.c 2002/05/24 04:32:28 1.33
> +++ src/lib/libc_r/uthread/uthread_cond.c 2002/11/13 18:13:26 1.34
>
> ...
>
> int
> -_pthread_cond_signal(pthread_cond_t * cond)
> +__pthread_cond_timedwait(pthread_cond_t *cond, pthread_mutex_t *mutex,
> + const struct timespec *abstime)
> +{
> + int ret;
> +
> + _thread_enter_cancellation_point();
> + ret = _pthread_cond_timedwait(cond, mutex, abstime);
> + _thread_enter_cancellation_point();
> + return (ret);
> +}
>
>
> ---------------------------->
>
> Shouldn't that be _thread_leave_cancellation_point() after
> calling _pthread_cond_timedwait() ?
> What effect should I see if this is wrong?
>
> Best regards,
>
> Norbert Koch
>
> _______________________________________________
> freebsd-hackers@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
> To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org"
> _______________________________________________
> freebsd-threads@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-threads
> To unsubscribe, send any mail to "freebsd-threads-unsubscribe@freebsd.org"
--
- Alfred Perlstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081021210444.GB22503>