Date: Sat, 19 Aug 2023 10:51:25 +0200 From: Mathieu Arnold <mat@freebsd.org> To: ports@freebsd.org Subject: Re: plist-check not reporting orphaned files present in a @comment Message-ID: <otzsqviyubxvmfuuhw6iutqxxlvh7pdyhvghd44mmjnlfsjlz3@6zz7aat23tag> In-Reply-To: <67hyj5pbnd2hf66tdj2szrtyhxozmjjcevw5rooas2vzrltxna@oqjzi7m5tfho> References: <5h3c6jbzs7y5k3hyimqn7jkyo3se3txvcywahpcffzc24hjew7@kx4mhnqq7gh4> <8raa-vofq-wny@FreeBSD.org> <2ppfted4t72jo2bhgxfmoghpm6zukhrcqevucxvouqqwehwugg@zy4chydjtuxy> <67hyj5pbnd2hf66tdj2szrtyhxozmjjcevw5rooas2vzrltxna@oqjzi7m5tfho>
next in thread | previous in thread | raw e-mail | index | archive | help
--kjdm7z7bhib5svja
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Wed, Aug 16, 2023 at 08:37:22PM +0200, Felix Palmen wrote:
> IMHO, the straight-forward solution would be: A port hit by that should
> add some "post-install-<opt>" (or -off) recipe explicitly removing the
> unwanted files from ${STAGEDIR}.
Well, it is a solution, but it is slower.
How it works now:
1. some file gets installed
2. that file is not in the plist, so it does not get packaged (actually
it is @comment'ed, but for pkg, it is the same thing as it not being
there)
So, that file only has one i/o operation, when it is installed, it then
is left there. It gets removed when `make clean` is ran, but so are all
files in WRKDIR, so the io hit is low because all the directory is
removed anyway.
What you want to do is :
1. some file gets installed
2. you run rm on it
So, the file now has two i/o operations associated to it, when it is
installed, and when it is removed. The io hit is higher because only
that file is removed, and then when `make clean` that directory gets hit
again.
It may not seems much for one port, but when you have 30k+ ports doing
that for many files, it adds up.
--=20
Mathieu Arnold
--kjdm7z7bhib5svja
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmTggo1fFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1
NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d
Qb5eZgwAmeXTU+KatsyUUBPZtojUdaQAAf2at3JXrT4eBCVyiphMjIRSNOarvbGI
X5UwB0J+1G/UQCcbDTC82ygniD+CmrpOPlIXUaZi/qY7WHK/UGsWQQEpswTKSTxO
8IKPOmtxNSkgsNs+9iazQlOigcq8jhG32FTmr0V6I823dSVMlOgou0CF4q1laE5f
zLjnNVatkrIGACEvBXCHBehUcgToN4Vh26EwEfYgjOnCTGTLqHLqrz59NMc3HoA4
oJ83u8JDxJ8lghLpJ2vcSeszPdZY4KowWqJkfVvdy1iy+0cmCCpD3UGYznrZU7wl
LJeS2aFT+lZBXY4eaIDn2iqaDWSIDJu9H9xWeMx0vSGKOxs+P9hjfjdGR90OfBGm
WPFP3cx4izEV+0tXKKp8R6lrKEt6pvpMeYXP9TsgqvkgBA5nqY54BGWAHqBJsnHe
2e7sPOMANZe635fFSijH2L0TS1gM1muYj84fy7TJJBv4KODyTAnFe1LoKRFldAxt
1YRh+Fvu
=9Sl6
-----END PGP SIGNATURE-----
--kjdm7z7bhib5svja--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?otzsqviyubxvmfuuhw6iutqxxlvh7pdyhvghd44mmjnlfsjlz3>