Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 16 Feb 2024 19:03:24 +0000
From:      bugzilla-noreply@freebsd.org
To:        pkgbase@FreeBSD.org
Subject:   [Bug 277096] WITHOUT_CLANG does not exclude SANITIZER_SHAREDIR from package file list
Message-ID:  <bug-277096-36141-WdKZm7gf41@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-277096-36141@https.bugs.freebsd.org/bugzilla/>
References:  <bug-277096-36141@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D277096

Dimitry Andric <dim@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dim@FreeBSD.org,
                   |                            |emaste@freebsd.org

--- Comment #1 from Dimitry Andric <dim@FreeBSD.org> ---
Hm, I don't see why only libclang_rt.asan-x86_64.so would be left? If you l=
ook
at lib/Makefile, it descends into the lib/libclang_rt directory (which prod=
uces
all the libclang_rt.* files, and the *_ignore_list.txt files), but it's only
gated on the compiler type:

# The libraries under libclang_rt can only be built by clang.
.if ${COMPILER_TYPE} =3D=3D "clang"
_libclang_rt=3D   libclang_rt
.elif (${MK_ASAN} !=3D "no" || ${MK_UBSAN} !=3D "no") && make(all)
.error Requested build with sanitizers but cannot build runtime libraries!
.endif

Ed, would we also need a test for MK_CLANG=3D=3Dno here?


E.g.:

.if ${COMPILER_TYPE} =3D=3D "clang" && ${MK_CLANG} !=3D "no"
_libclang_rt=3D   libclang_rt
.elif (${MK_ASAN} !=3D "no" || ${MK_UBSAN} !=3D "no") && make(all)
.error Requested build with sanitizers but cannot build runtime libraries!
.endif

--=20
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-277096-36141-WdKZm7gf41>