Date: Thu, 22 Apr 2021 12:16:16 +0200 From: Mathieu Arnold <mat@freebsd.org> To: Michael Gmelin <grembo@freebsd.org> Cc: Alexey Dokuchaev <danfe@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 5b7c17856512 - main - git hooks: Rework authorship instructions. Message-ID: <20210422101616.c3i7dn6gfm6hhner@aching.in.mat.cc> In-Reply-To: <FB32E75F-9AF0-41C2-9EE1-B10D931DECD0@freebsd.org> References: <YIFK/tIpcfqWTWVh@FreeBSD.org> <FB32E75F-9AF0-41C2-9EE1-B10D931DECD0@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--zeux5tzlgtphbk4c
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Thu, Apr 22, 2021 at 12:10:26PM +0200, Michael Gmelin wrote:
>=20
>=20
> > On 22. Apr 2021, at 12:08, Alexey Dokuchaev <danfe@freebsd.org> wrote:
> >=20
> > =EF=BB=BFOn Thu, Apr 22, 2021 at 09:52:19AM +0000, Mathieu Arnold wrote:
> >> ...
> >> diff --git a/.hooks/prepare-commit-msg b/.hooks/prepare-commit-msg
> >> @@ -44,6 +44,9 @@ $(awk '1;/^#$/{exit}' "$1")
> >> # <then a blank line>
> >> # 72 columns -=
-|
> >> #
> >> +# Do not add a Submitted by line. If someone besides the committer s=
ent in the
> >> +# change, the commit author should be set using \`git commit --author=
\`.
> >> +#
> >=20
> > This doesn't seem right. "Submitted by" can be a list, not a single na=
me.
> > Also, I rarely commit submitted work verbatim, so technically the author
> > is me 99% of the time, yet it would be appropriate to give attribution =
to
> > the original submitter, esp. if there is no PR number (private submissi=
on).
> >=20
>=20
> I agree that author should only be used if a submission is applied unalte=
red (pull request/git patch).
Submitted by has always been for submission that was unaltered (or only
slightly altered) if it was only the basis of the work, then "submitted
by" is not to be used, in those cases, reported by is the correct
choice.
As for the multiple authors, do multiple commits, stop piling up stuff
in only one commit.
--=20
Mathieu Arnold
--zeux5tzlgtphbk4c
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQKTBAABCgB9FiEEVhwchfRfuV0unqO5KesJApEdfgIFAmCBTOxfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU2
MUMxQzg1RjQ1RkI5NUQyRTlFQTNCOTI5RUIwOTAyOTExRDdFMDIACgkQKesJApEd
fgIwlRAApSic59MvVW/mUGtV2VzeFR2E5Nbf1A0dSHqRjPtNbBUmCZEmkZM9x6b5
55LhjXoq1ku+D2eRlkwVLstLxD0Hrvx95yrfc7tA5zzSAvdOw947VEkPTyjE/Vz4
BdfcrdQnLa2qMhJQ+bPlBUSwjwU58RFEItfkb+CWEdPOgSFDzq6/O7FG8aUMhhd3
dSnOcC3+M1DbOGyt7m21mwgaMHTOWOv2J5DQmNBY8Tw4CI38cceAg6kGNSx8XJh4
c2FEJ0fPPITjhgAWzLKlxqtU89OnQ9ifnmYO3TvJ4YTCpxVPdQU3JrR1I7Bm/Ad1
Be203Vu1jozTq3ufrT8+R2aMm1YrE9Za2cGBBwZXPfNe74GQ6rdS/9M6mpWK+2sy
c4RcW3IKPqX2W3nd5BCCMsXH7i/RrtVNuMN4i0l55DJ41dHlu/6vMSgM1ZYlvE9C
R8hUEPTBcEYrYhOUYkDM/40IpiN0y4FLsdnRYD7p/oEr+RTwC2EOhrdm8DfiDWIA
dDAkBaTN0/wlRTQ/kk/ksxe56yVxMTf24Hlya9AFXnUHn6SJS5s5UlMwg4DjzwaR
HYEo+4bcu+ZSpf2dikkR2a3FMQNrIiWoqMtSfRe/dEU2AOZ7YyIrxqB09E8gl41N
c4ZoRrwMCaOFOpgcH5L7s3H3QH+QJJ+sVySS4OPMhMqmhjQog+0=
=FxXy
-----END PGP SIGNATURE-----
--zeux5tzlgtphbk4c--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210422101616.c3i7dn6gfm6hhner>