Date: Fri, 21 Feb 2025 13:03:39 -0800 From: Gleb Smirnoff <glebius@freebsd.org> To: Kristof Provost <kp@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 8754ba5a5f6e - main - pfctl: Rewrite to void using union sockaddr_union Message-ID: <Z7jqKx1iAhmO6gpe@cell.glebi.us> In-Reply-To: <202502210811.51L8Bkhe075894@gitrepo.freebsd.org> References: <202502210811.51L8Bkhe075894@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Kristof, On Fri, Feb 21, 2025 at 08:11:46AM +0000, Kristof Provost wrote: K> commit 8754ba5a5f6ee681de776601110313b69a779067 K> Author: Kristof Provost <kp@FreeBSD.org> K> AuthorDate: 2025-02-13 17:30:12 +0000 K> Commit: Kristof Provost <kp@FreeBSD.org> K> CommitDate: 2025-02-21 08:11:02 +0000 K> K> pfctl: Rewrite to void using union sockaddr_union K> K> ok mikeb K> K> Obtained from: OpenBSD, deraadt <deraadt@openbsd.org>, 8717211fe3 What a nice typo in the commit message! This is how I read it: use void * pointer to sockaddr_union So I was expection to see introduction of sockaddr_union, not removal :) Maybe makes sense to not copy upstream commit messages verbatim, at least in some cases. -- Gleb Smirnoff
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Z7jqKx1iAhmO6gpe>