Date: Mon, 26 Oct 2009 09:20:05 GMT From: Jaakko Heinonen <jh@FreeBSD.org> To: freebsd-scsi@FreeBSD.org Subject: Re: kern/130735: [patch] pass M_NOWAIT to the malloc() call inside cdreaddvdstructure() Message-ID: <200910260920.n9Q9K5uR048430@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/130735; it has been noted by GNATS. From: Jaakko Heinonen <jh@FreeBSD.org> To: Eygene Ryabinkin <rea-fbsd@codelabs.ru> Cc: bug-followup@FreeBSD.org Subject: Re: kern/130735: [patch] pass M_NOWAIT to the malloc() call inside cdreaddvdstructure() Date: Mon, 26 Oct 2009 11:19:20 +0200 Hi, On 2009-10-24, Eygene Ryabinkin wrote: > I am feeling myself lucky today -- may be someone will be able > to look at this PR and fix the bad malloc() invocation? I have been looking at this. The same problem also exists in cdreportkey() and cdsendkey(). I think that it's better to drop periph lock while doing M_WAITOK malloc instead of using M_NOWAIT. Could you test and look at this patch: http://www.saunalahti.fi/~jh3/patches/scsi_cd-M_WAITOK-fixes.diff -- Jaakko
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200910260920.n9Q9K5uR048430>