Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 26 Apr 2005 11:22:38 GMT
From:      Robert Watson <rwatson@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 75997 for review
Message-ID:  <200504261122.j3QBMcOj095648@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help

http://perforce.freebsd.org/chv.cgi?CH=75997

Change 75997 by rwatson@rwatson_paprika on 2005/04/26 11:22:22

	Make sure to properly initialize 'retval' for the success case
	when writing an audit record to a buffer.
	
	Remove unused 'dptr', frobbing the internals of records occurs
	only in au_assemble() now.

Affected files ...

.. //depot/projects/trustedbsd/openbsm/libbsm/bsm_audit.c#8 edit

Differences ...

==== //depot/projects/trustedbsd/openbsm/libbsm/bsm_audit.c#8 (text+ko) ====

@@ -259,7 +259,6 @@
 int au_close(int d, int keep, short event)
 {
 	au_record_t *rec;
-	u_char *dptr;
 	size_t tot_rec_size;
 	int retval = 0;
 		
@@ -322,6 +321,7 @@
 		return (-1);
 	}
 
+	retval = 0;
 	tot_rec_size = rec->len + BSM_HEADER_SIZE + BSM_TRAILER_SIZE;
 	if ((tot_rec_size > MAX_AUDIT_RECORD_SIZE) ||
 	    (tot_rec_size > *buflen)) {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200504261122.j3QBMcOj095648>