Date: Fri, 15 Sep 2017 13:18:16 -0400 From: Steve Wills <swills@FreeBSD.org> To: =?UTF-8?Q?Dag-Erling_Sm=c3=b8rgrav?= <des@des.no> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r449798 - head/net-mgmt/collectd5 Message-ID: <13547d29-d79f-1b13-ac1e-bd6e8c20be8e@FreeBSD.org> In-Reply-To: <8660cki73w.fsf@desk.des.no> References: <201709131455.v8DEtjVq069144@repo.freebsd.org> <305b87d4-297e-e569-7011-9c322984206d@FreeBSD.org> <8660cki73w.fsf@desk.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, On 09/15/2017 06:33, Dag-Erling Smørgrav wrote: > Steve Wills <swills@FreeBSD.org> writes: >> I'm happy to see more options enabled by default in this port, thanks >> for that. We do have a policy that packaged binaries should be >> stripped. Enabling the DEBUG option by default would seem to be at >> odds with that policy to me. Could you please turn that one off by >> default? > > # file /usr/local/sbin/collectd > /usr/local/sbin/collectd: ELF 64-bit LSB executable, x86-64, version 1 (FreeBSD), dynamically linked, interpreter /libexec/ld-elf.so.1, for FreeBSD 11.0 (1100122), FreeBSD-style, stripped > Hmm, mine built after this change shows: /usr/local/sbin/collectd: ELF 64-bit LSB executable, x86-64, version 1 (FreeBSD), dynamically linked, interpreter /libexec/ld-elf.so.1, for FreeBSD 12.0 (1200042), FreeBSD-style, not stripped > The DEBUG option enables log messages which are indispensable when > troubleshooting a collectd installation (or rather, makes an additional > log level available). I didn't realize that it also disables stripping. > If that is the case, it needs to be split in two, or maybe the relevant > configure argument should simply be hardcoded. Simply renaming the DEBUG option to LOGGING seems to avoid the issue: /usr/local/sbin/collectd: ELF 64-bit LSB executable, x86-64, version 1 (FreeBSD), dynamically linked, interpreter /libexec/ld-elf.so.1, for FreeBSD 12.0 (1200042), FreeBSD-style, stripped Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?13547d29-d79f-1b13-ac1e-bd6e8c20be8e>