Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 25 Sep 2021 10:55:28 -0500
From:      Kyle Evans <kevans@freebsd.org>
To:        Shawn Webb <shawn.webb@hardenedbsd.org>
Cc:        Konstantin Belousov <kib@freebsd.org>, src-committers <src-committers@freebsd.org>,  "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-main@freebsd.org
Subject:   Re: git: 24a3897c2c32 - main - x86 bounce_bus_dmamem_alloc(): use malloc_aligned() only when possible
Message-ID:  <CACNAnaGOmE-O6REwxnrMW0DJ_FS1oghskpq76h5i49WOjYrrQQ@mail.gmail.com>
In-Reply-To: <20210925131801.b4lyozg7b56646x4@mutt-hbsd>
References:  <202109251311.18PDBVqf077216@gitrepo.freebsd.org> <20210925131801.b4lyozg7b56646x4@mutt-hbsd>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Sep 25, 2021 at 8:18 AM Shawn Webb <shawn.webb@hardenedbsd.org> wrote:
>
> On Sat, Sep 25, 2021 at 01:11:31PM +0000, Konstantin Belousov wrote:
> > The branch main has been updated by kib:
> >
> > URL: https://cgit.FreeBSD.org/src/commit/?id=24a3897c2c3205c2ec0cf323c555c403d3171e2c
> >
> > commit 24a3897c2c3205c2ec0cf323c555c403d3171e2c
> > Author:     Konstantin Belousov <kib@FreeBSD.org>
> > AuthorDate: 2021-09-24 17:46:47 +0000
> > Commit:     Konstantin Belousov <kib@FreeBSD.org>
> > CommitDate: 2021-09-25 12:58:12 +0000
> >
> >     x86 bounce_bus_dmamem_alloc(): use malloc_aligned() only when possible
> >
> >     malloc_domainset_aligned() requires that alignment is less than
> >     page size. Fall back to other allocation methods, most likely
> >     kmem_alloc_contig(), when malloc_aligned() cannot fullfill the driver
> >     request.
> >
> >     Reported by:    Loic F <loic.f@hardenedbsd.org>
> >     Reviewed by:    markj
> >     Sponsored by:   The FreeBSD Foundation
> >     MFC after:      1 week
> >     Differential revision:  https://reviews.freebsd.org/D32127
>
> Wrong Differential revision URL? The patch in the URL doesn't match
> what was committed here.
>

No; there were two patches included, and Phabricator always updates
the diff to the first one that closed it. You can check the history on
the diff to find the last one pre-commit.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaGOmE-O6REwxnrMW0DJ_FS1oghskpq76h5i49WOjYrrQQ>