Skip site navigation (1)Skip section navigation (2) 
Date:      Thu, 20 Feb 2014 20:14:43 +0000 (UTC)
From:      Michael Tuexen <tuexen@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r262252 - head/sys/netinet
Message-ID:  <201402202014.s1KKEhXS033490@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: tuexen
Date: Thu Feb 20 20:14:43 2014
New Revision: 262252
URL: http://svnweb.freebsd.org/changeset/base/262252

Log:
  Remove redundant code and fix a style error.
  
  MFC after: 3 days

Modified:
  head/sys/netinet/sctp_input.c
  head/sys/netinet/sctp_output.c

Modified: head/sys/netinet/sctp_input.c
==============================================================================
--- head/sys/netinet/sctp_input.c	Thu Feb 20 20:09:28 2014	(r262251)
+++ head/sys/netinet/sctp_input.c	Thu Feb 20 20:14:43 2014	(r262252)
@@ -439,7 +439,6 @@ sctp_process_init_ack(struct mbuf *m, in
 
 	/* First verify that we have no illegal param's */
 	abort_flag = 0;
-	op_err = NULL;
 
 	op_err = sctp_arethere_unrecognized_parameters(m,
 	    (offset + sizeof(struct sctp_init_chunk)),
@@ -1553,8 +1552,7 @@ sctp_process_cookie_existing(struct mbuf
 			return (NULL);
 
 		}
-		switch SCTP_GET_STATE
-			(asoc) {
+		switch (SCTP_GET_STATE(asoc)) {
 		case SCTP_STATE_COOKIE_WAIT:
 		case SCTP_STATE_COOKIE_ECHOED:
 			/*
@@ -1644,7 +1642,7 @@ sctp_process_cookie_existing(struct mbuf
 			 * have simply lost the COOKIE-ACK
 			 */
 			break;
-			}	/* end switch */
+		}		/* end switch */
 		sctp_stop_all_cookie_timers(stcb);
 		/*
 		 * We ignore the return code here.. not sure if we should

Modified: head/sys/netinet/sctp_output.c
==============================================================================
--- head/sys/netinet/sctp_output.c	Thu Feb 20 20:09:28 2014	(r262251)
+++ head/sys/netinet/sctp_output.c	Thu Feb 20 20:14:43 2014	(r262252)
@@ -3671,7 +3671,6 @@ sctp_add_cookie(struct mbuf *init, int i
 	int sig_offset;
 	uint16_t cookie_sz;
 
-	mret = NULL;
 	mret = sctp_get_mbuf_for_msg((sizeof(struct sctp_state_cookie) +
 	    sizeof(struct sctp_paramhdr)), 0,
 	    M_NOWAIT, 1, MT_DATA);
@@ -8960,7 +8959,6 @@ sctp_send_cookie_ack(struct sctp_tcb *st
 	struct sctp_chunkhdr *hdr;
 	struct sctp_tmit_chunk *chk;
 
-	cookie_ack = NULL;
 	SCTP_TCB_LOCK_ASSERT(stcb);
 
 	cookie_ack = sctp_get_mbuf_for_msg(sizeof(struct sctp_chunkhdr), 0, M_NOWAIT, 1, MT_HEADER);

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201402202014.s1KKEhXS033490>