Date: Sat, 1 Jul 2023 21:44:05 GMT From: John Baldwin <jhb@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 84deca4d8ca2 - main - libkern: Trim OBE comment from divmoddi routines. Message-ID: <202307012144.361Li5io001630@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=84deca4d8ca2e188b233a45d503443b17088c788 commit 84deca4d8ca2e188b233a45d503443b17088c788 Author: John Baldwin <jhb@FreeBSD.org> AuthorDate: 2023-07-01 21:43:53 +0000 Commit: John Baldwin <jhb@FreeBSD.org> CommitDate: 2023-07-01 21:43:53 +0000 libkern: Trim OBE comment from divmoddi routines. -1/2 is defined to be 0 in modern C. Reviewed by: jrtc27 Differential Revision: https://reviews.freebsd.org/D40833 --- sys/libkern/divdi3.c | 1 - sys/libkern/divmoddi4.c | 1 - sys/libkern/moddi3.c | 3 --- 3 files changed, 5 deletions(-) diff --git a/sys/libkern/divdi3.c b/sys/libkern/divdi3.c index 11c34ed72fa0..8e04a81abdba 100644 --- a/sys/libkern/divdi3.c +++ b/sys/libkern/divdi3.c @@ -40,7 +40,6 @@ __FBSDID("$FreeBSD$"); /* * Divide two signed quads. - * ??? if -1/2 should produce -1 on this machine, this code is wrong */ quad_t __divdi3(quad_t a, quad_t b) diff --git a/sys/libkern/divmoddi4.c b/sys/libkern/divmoddi4.c index 7c0a6a690f24..af0013532882 100644 --- a/sys/libkern/divmoddi4.c +++ b/sys/libkern/divmoddi4.c @@ -37,7 +37,6 @@ /* * Divide two signed quads. - * ??? if -1/2 should produce -1 on this machine, this code is wrong */ quad_t __divmoddi4(quad_t a, quad_t b, quad_t *rem) diff --git a/sys/libkern/moddi3.c b/sys/libkern/moddi3.c index 0e93b7d9f6eb..0dbff4bdce89 100644 --- a/sys/libkern/moddi3.c +++ b/sys/libkern/moddi3.c @@ -40,9 +40,6 @@ __FBSDID("$FreeBSD$"); /* * Return remainder after dividing two signed quads. - * - * XXX - * If -1/2 should produce -1 on this machine, this code is wrong. */ quad_t __moddi3(quad_t a, quad_t b)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202307012144.361Li5io001630>