Date: Tue, 20 Mar 2007 10:06:11 +0300 From: Eygene Ryabinkin <rea-fbsd@codelabs.ru> To: Jung-uk Kim <jkim@FreeBSD.org>, Nate Lawson <nate@root.org> Cc: acpi@freebsd.org, current@freebsd.org Subject: Re: [HEADSUP] ACPI-CA 20070126 import Message-ID: <20070320070610.GE96806@codelabs.ru> In-Reply-To: <45FF3239.7080808@root.org> <200703191538.32383.jkim@FreeBSD.org> References: <200703161256.23996.jkim@FreeBSD.org> <53B52415C756A84E8A169F0E3673A32925FF83@IMCSRV6.MITRE.ORG> <20070319163113.GB96806@codelabs.ru> <45FEF6A6.30209@root.org> <45FF3239.7080808@root.org> <200703161256.23996.jkim@FreeBSD.org> <20070319163113.GB96806@codelabs.ru> <200703191535.27842.jkim@FreeBSD.org> <200703191538.32383.jkim@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Jung-uk, Nate, good day. Mon, Mar 19, 2007 at 06:00:41PM -0700, Nate Lawson wrote: > > > I think it's not the acpi-ca patch, it's the recent acpi_ec.c change. > > Try it with rev 1.68 of that file. > > > > Or better, try with rev 1.71 that I just committed. Fixed a bug where > we weren't re-enabling the GPE, which could cause exactly this issue. Nate, you're completely right: I've applied the 1.70 -> 1.71 patch on top of the Jung-uk's one and it enabled the backlight controls to work again. But the "queued" behaviour were still there. Mon, Mar 19, 2007 at 03:38:30PM -0400, Jung-uk Kim wrote: > > As a quick test, can you try this? > > --- src/sys/dev/acpica/Osd/OsdSchedule.c > +++ src/sys/dev/acpica/Osd/OsdSchedule.c > pri = 5; > break; > case OSL_NOTIFY_HANDLER: > - pri = 3; > + pri = 15; > break; > case OSL_DEBUGGER_THREAD: > pri = 0; Jung-uk, and this change enabled the backlignt to go up or down after the second press of any F-button, so the "event queue" length got down to one. Again, your patch was applied to the yesterday's clean FreeBSD HEAD and the Nate's one for the acpi_ec.c 1.70 -> 1.71 was applied on top of it. > BTW, it is not really a patch, i.e., I just typed it in. :-) All I > want you to test is to change 3 -> 15. > > I hope I didn't confuse you. No, you're not confused me at all -- I am doing such "patches" almost regularily ;)) Thank you both for your response and work! -- Eygene
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070320070610.GE96806>