Date: Sat, 14 Sep 2019 09:14:56 -0600 From: Ian Lepore <ian@freebsd.org> To: Warner Losh <imp@bsdimp.com>, Peter Jeremy <peter@rulingia.com> Cc: Baptiste Daroussin <bapt@freebsd.org>, Charlie Li <ml+freebsd@vishwin.info>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r352275 - in head/lib/libedit: . TEST edit readline Message-ID: <1f18e7e147790aa280a4d35f93bf619313745200.camel@freebsd.org> In-Reply-To: <CANCZdfocTme=zHcA%2BtbdLqmZFpJEr-bRYZ22FCDBqk06=XdSEw@mail.gmail.com> References: <201909130650.x8D6o2fb037276@repo.freebsd.org> <6fadeb6b-fe09-f3c7-9bca-b5637bbb4e43@vishwin.info> <20190914041041.GA97181@server.rulingia.com> <CANCZdfocTme=zHcA%2BtbdLqmZFpJEr-bRYZ22FCDBqk06=XdSEw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 2019-09-13 at 22:25 -0600, Warner Losh wrote: > On Fri, Sep 13, 2019, 10:11 PM Peter Jeremy <peter@rulingia.com> > wrote: > > > On 2019-Sep-13 16:33:15 -0400, Charlie Li <ml+freebsd@vishwin.info> > > wrote: > > > Baptiste Daroussin wrote: > > > > Author: bapt > > > > Date: Fri Sep 13 06:50:02 2019 > > > > New Revision: 352275 > > > > URL: https://svnweb.freebsd.org/changeset/base/352275 > > > > > > > > Log: > > > > Update libedit to a snapshot from 2019-09-10 > > > > Reviewed by: Yuichiro Naito <naito.yuichiro_gmail.com> > > > > MFC after: 3 weeks > > > > Differential Revision: https://reviews.freebsd.org/D21584 > > > > > > > > > > I posted in phab but repeating here, this breaks the build on (at > > > least) > > > aarch64: > > > > It breaks the build on arm and arm64 only. > > > > wint_t is int on all platforms: > > sys/sys/_types.h: > > typedef int __ct_rune_t; /* arg type for ctype funcs > > */ > > typedef __ct_rune_t __wint_t; /* wint_t (see above) */ > > > > but wchar_t varies between unsigned and signed: > > $ grep '__wchar_t' sys/*/include/_types.h > > sys/arm/include/_types.h:typedef unsigned int ___wchar_t; > > sys/arm64/include/_types.h:typedef unsigned int ___wchar_t; > > sys/mips/include/_types.h:typedef int ___wchar_t; > > sys/powerpc/include/_types.h:typedef int ___wchar_t; > > sys/riscv/include/_types.h:typedef int ___wchar_t; > > sys/sparc64/include/_types.h:typedef int ___wchar_t; > > sys/x86/include/_types.h:typedef int ___wchar_t; > > > > Looking back into history, it looks like the "unsigned" is part > > of the ARM EABI. > > > > We should confirm that. It is definitely part of the OABI stuff, but EABI > was supposed to fix differences like this... > The char type is unsigned by default on arm (it's part of eabi), and also on powerpc and riscv. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1f18e7e147790aa280a4d35f93bf619313745200.camel>