Date: Mon, 28 Feb 2011 01:18:32 -0300 From: Marcelo Araujo <araujobsdport@gmail.com> To: Doug Barton <dougb@freebsd.org> Cc: cvs-ports@freebsd.org, ports-committers@freebsd.org, cvs-all@freebsd.org, Sahil Tandon <sahil@freebsd.org> Subject: Re: cvs commit: ports/net/trafshow Makefile distinfo Message-ID: <AANLkTi=Bok1He-1Ft-_yic6zLajnWPqB06meDBfSmZJw@mail.gmail.com> In-Reply-To: <4D6AB7BD.2060203@FreeBSD.org> References: <201102271441.p1REfMrT016669@repoman.freebsd.org> <20110227193203.GA38353@magic.hamla.org> <4D6AB7BD.2060203@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2011/2/27 Doug Barton <dougb@freebsd.org> > On 02/27/2011 11:32, Sahil Tandon wrote: > >> On Sun, 2011-02-27 at 14:41:22 +0000, Marcelo Araujo wrote: >> >> araujo 2011-02-27 14:41:22 UTC >>> >>> FreeBSD ports repository >>> >>> Modified files: >>> net/trafshow Makefile distinfo >>> Log: >>> - Now can build with supporting of IPV6. >>> - Removed MD5. >>> - Bump PORTREVISION. >>> >> >> If the IPv6 option is off by default (and thus, does not affect the >> default package), why do you bump PORTREVISION? I just want to >> understand for my own edification when dealing with similar situations. >> > > Sahil is right, if the change does not affect the package no bump is > needed. > > OTOH, my personal feeling is that we should default all IPV6 knobs to on. > :) > > > Well, I've used the latest paragraph that discribe when we should bump PORTREVISION. """A rule of thumb is to ask yourself whether a change committed to a port is something which someone, somewhere, would benefit from having (either because of an enhancement, fix, or by virtue that the new package will actually work for them). If yes, the PORTREVISION should be bumped so that automated tools (e.g. pkg_version) will highlight the fact that a new package is available.""" As the IPv6 option can be a good enhancement for trafshow, I decided to BUMP PORTREVISION. I believe in this case it is OK. If not, please someone else correct me. I'm gonna checking how the other ports dealing with IPv6 support, then I'm gonna check if it stay like now or put it by default ON. Best Regards, - Araujo
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTi=Bok1He-1Ft-_yic6zLajnWPqB06meDBfSmZJw>