Date: Thu, 23 Mar 2006 17:04:17 +0200 From: Ion-Mihai Tetcu <itetcu@people.tecnik93.com> To: "Frank W. Josellis" <frank@dynamical-systems.org> Cc: Thierry Thomas <thierry@FreeBSD.org>, freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/93972: Update port: astro/xmoontool to 3.0.3 Message-ID: <20060323170417.7dfeaa48@it.buh.tecnik93.com> In-Reply-To: <20060323133612.J6641@pollux.senax.net> References: <200603222154.k2MLsUZJ038943@freefall.freebsd.org> <20060323133612.J6641@pollux.senax.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 23 Mar 2006 14:29:12 +0100 (CET) "Frank W. Josellis" <frank@dynamical-systems.org> wrote: > > > On Wed, 22 Mar 2006, Thierry Thomas wrote: > > > This port does not respect CFLAGS, CC nor PREFIX; what about the > > following patch? (Since I'm there, reorganize Makefile) > > You are right, but please note that patching PREFIX into the tarball's > Makefile has no effect on the port. It's only the install target that > involves PREFIX. This isn't used, as the port's installation is solely > carried out by do-install in the port's Makefile. > > Well, I considered the tarball's CC and CFLAGS settings as acceptable for > the port and couldn't imagine a situation where it is essential to have > them overwritten. But I suppose you are more acquainted with the formal > requirements on FreeBSD ports, so I better leave it to you. If you feel > it's an advantage which justifies the patch, I won't protest. > > I wasn't yet aware that USE_REINPLACE meanwhile became obsolete, but I'll > know in future. Run a `portlint -A` in the port directory will help you with a lot of interesting things ;) -- IOnut - Unregistered ;) FreeBSD "user" "Intellectual Property" is nowhere near as valuable as "Intellect" Ferengi Rule of Acquisition #144: There's nothing wrong with charity... as long as it winds up in your -- ST: Legends of the Ferengi
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060323170417.7dfeaa48>