Date: Thu, 19 Apr 2012 09:38:50 +0200 From: Bernhard Froehlich <decke@FreeBSD.org> To: AN <andy@neu.net> Cc: sobomax@FreeBSD.org, freebsd-emulation@freebsd.org, Petro Rossini <petro.rossini@gmail.com> Subject: Re: VBox upgrade fails (ML_CLANG_IS_CC again) Message-ID: <ca1dec8134a0be73f4ba90771f3eef90@bluelife.at> In-Reply-To: <alpine.BSF.2.00.1204190329210.36406@mail.neu.net> References: <alpine.BSF.2.00.1204172001310.30965@mail.neu.net> <CAExkqpeOFVb-NuUk_xYfYwHfRceR3DA_Y-xxvOyJqB3Jo5XP1w@mail.gmail.com> <alpine.BSF.2.00.1204172024370.30965@mail.neu.net> <4F8E0C85.7010605@gmail.com> <alpine.BSF.2.00.1204181553380.34141@mail.neu.net> <CAExkqpdwroWXqQ364PGyJiLeTVeAPN6H-rjORtXJwAVojCUT3g@mail.gmail.com> <alpine.BSF.2.00.1204190329210.36406@mail.neu.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 19.04.2012 09:33, AN wrote:
> On Thu, 19 Apr 2012, Petro Rossini wrote:
>
>> On Thu, Apr 19, 2012 at 6:02 AM, AN <andy@neu.net> wrote:
>>>
>>> # portupgrade -va
>>> ---> Session started at: Wed, 18 Apr 2012 15:56:15 -0400
>>> ---> Upgrade of emulators/virtualbox-ose-kmod started at: Wed, 18
>>> Apr 2012
>>> 15:57:23 -0400
>>> ---> Upgrading 'virtualbox-ose-kmod-4.1.8_1' to
>>> 'virtualbox-ose-kmod-4.1.12' (emulators/virtualbox-ose-kmod)
>>> ---> Build of emulators/virtualbox-ose-kmod started at: Wed, 18
>>> Apr 2012
>>> 15:57:23 -0400
>>> ---> Building '/usr/ports/emulators/virtualbox-ose-kmod'
>>> ===> Cleaning for virtualbox-ose-kmod-4.1.12
>>> cd
>>>
>>> /usr/ports/emulators/virtualbox-ose-kmod/work/VirtualBox-4.1.12/out/freebsd.amd64/release/bin/src
>>> && make SYSDIR=/usr/src/sys
>>> *** Building 'vboxdrv' module ***
>>> "/usr/share/mk/bsd.own.mk", line 483: MK_CLANG_IS_CC can't be set
>>> by a user.
>>> *** [all] Error code 1
>>>
>>> I think it is a problem with the file /usr/share/mk/bsd.own.mk. I
>>> will
>>> send a message to the ports list.
>>
>> I looked into it.
>>
>> I tend to believe that the VirtualBox patches for FreeBSD modifying
>> the Makefiles are the problem.
>>
>> [root@DellT410two /usr/ports/emulators/virtualbox-ose-kmod]# find .
>> -type f -exec fgrep -H MK_CLANG_IS_CC {} \;
>>
>> ./files/patch-src_VBox_HostDrivers_VBoxNetAdp_freebsd_Makefile:+MK_CLANG_IS_CC
>> ?= no
>>
>> ./files/patch-src_VBox_HostDrivers_Support_freebsd_Makefile:+MK_CLANG_IS_CC
>> ?= no
>>
>> ./files/patch-src_VBox_HostDrivers_VBoxNetFlt_freebsd_Makefile:+MK_CLANG_IS_CC
>> ?= no
>>
>> According to
>> http://www.freebsd.org/cgi/cvsweb.cgi/src/share/mk/bsd.own.mk,
>> Revision 1.107.2.5,
>>
>> this parameter decides whether the CLANG compiler is installed as
>> /usr/bin/cc.
>>
>> VirtualBox does not install the cc (that's done by installworld of
>> the
>> base system build) so to set the variable here does not make sense
>> to
>> me.
>>
>> Regards
>> Peter
>>
>
> The following fix was provided by someone on the ports list.
>
> cd /usr/ports/emulators/virtualbox-ose-kmod/files &&
> rm patch-src_VBox_HostDrivers_Support_freebsd_Makefile
> patch-src_VBox_HostDrivers_VBoxNetAdp_freebsd_Makefile
> patch-src_VBox_HostDrivers_VBoxNetFlt_freebsd_Makefile
> and start the update again
>
> VBox upgrade completed successfully.
I wasn't involved in committing those patches so I've cc'd Maksym
Sobolyev
to see if there is something new about those patches.
--
Bernhard Froehlich
http://www.bluelife.at/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ca1dec8134a0be73f4ba90771f3eef90>