Date: Fri, 31 May 2002 13:52:18 -0700 (PDT) From: Julian Elischer <julian@elischer.org> To: Archie Cobbs <archie@dellroad.org> Cc: Bosko Milekic <bmilekic@unixdaemons.com>, freebsd-net@FreeBSD.ORG Subject: Re: m_split() considered harmful Message-ID: <Pine.BSF.4.21.0205311349260.29361-100000@InterJet.elischer.org> In-Reply-To: <200205312025.g4VKP9t02205@arch20m.dellroad.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 31 May 2002, Archie Cobbs wrote: > > It's not clear whether the caller of M_TRAILINGSPACE()/M_LEADINGSPACE() > is responsible for checking for writability, or the macros themselves. > It seems to make more sense that the caller would be responsible... > why would you call M_TRAILINGSPACE() unless you wanted to write > something in there? > M_TRAILINGSPACE is called to ask "How much writable room is there after hte data here? if the module is not writable the answer should always be "none". your patch looks better now I'm wouldering however if any code other than that looks at ext_size To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0205311349260.29361-100000>