Date: Thu, 5 Apr 2001 18:18:45 +0400 From: "Andrey A. Chernov" <ache@nagual.pp.ru> To: Mark.Andrews@nominum.com Cc: freebsd-security@FreeBSD.ORG Subject: Re: ntpd: committed fix still contains buffer overrun Message-ID: <20010405181844.A98479@nagual.pp.ru> In-Reply-To: <200104050545.f355jVT38066@drugs.dv.isc.org>; from Mark.Andrews@nominum.com on Thu, Apr 05, 2001 at 03:45:31PM %2B1000 References: <200104050545.f355jVT38066@drugs.dv.isc.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Apr 05, 2001 at 15:45:31 +1000, Mark.Andrews@nominum.com wrote: > - while (isspace((int)(*(tp-1)))) > + while (tp != buf && > + isspace((int)(*(tp-1)))) I wonder how many different variants of wrong cast people use in that place: int, unsigned, etc. Proper cast is one: (unsigned char) Please, fix. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-security" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010405181844.A98479>